AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 44 Bitcoin

feat: onchain wallet type (#4194)

Public commit record

What the developer wrote

Authored by Arc

65/100 · Adequate
feat: onchain wallet type (#4194)
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This is a large feature commit that adds native on-chain Bitcoin wallets to LNbits. It introduces new wallet types, address generation, blockchain scanning, transaction signing (including hot wallets), and an encryption key system for recovery phrases. Because this is new code handling real Bitcoin funds and private keys, it carries inherent security risk, but the diff itself does not show an obvious, already-implemented vulnerability. It is a feature addition rather than a documented security fix.

Recommended action

Treat this as a high-risk feature addition requiring focused security review and testing before production use. Prioritize audit of: hot wallet key generation and encryption, the onchain signing service, admin key backup/restore endpoints, access control decorators, and the block explorer/Mempool client input validation. Run the new onchain unit and e2e tests, and consider additional review of the full diff beyond the truncated portion supplied.

Security signals we found

01

New feature handling private key material and real Bitcoin funds

02

Server-side hot wallet signing with encrypted mnemonics

03

New admin API endpoints for encryption key setup/backup/restore

04

Super-user restriction on enabling onchain payments

05

Database fingerprint pinning of encryption key

06

Lease-based coordination for blockchain scans

07

Input ownership and network validation in signing path

08

Large diff with many new files and limited visible review coverage

Risk score

Why this scored 44/100

Our methodology →
Potential impact 12/30
Exploitability 8/25
Stealth signal 6/15
Affected reach 10/15
Confidence 5/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.