ci, refactor: Generalize use of `matrix.configuration.env_vars`
What the developer wrote
Authored by Hennadii Stepanov
ci, refactor: Generalize use of `matrix.configuration.env_vars`
What changed, and why it matters
This is a routine cleanup of the project's automated testing configuration. It renames and restructures how environment variables are grouped in GitHub Actions workflow files so the setup is more consistent across different test jobs. There is no change to the actual cryptographic code, no new capability for an attacker, and no security fix.
No security action needed. Treat as normal maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit refactors .github/workflows/ci.yml by introducing a matrix.configuration key that wraps existing env_vars settings. Previously only the valgrind_debian job used matrix.env_vars; now every job uses matrix.configuration.env_vars, including jobs that previously had no matrix at all. The valgrind job’s runner and binary_arch fields are moved under configuration as well. This is purely a YAML structural change with no functional effect on the CI environment passed to the run-in-docker-action.
Changed components
.github/workflows/ci.ymlInspect captured patch +28 / −4
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 7195b7d..07a574d 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -130,6 +130,8 @@ jobs:
strategy:
fail-fast: false
matrix:
+ configuration:
+ - env_vars: {}
cc:
- 'i686-linux-gnu-gcc'
- 'clang --target=i686-pc-linux-gnu -isystem /usr/i686-linux-gnu/include'
@@ -148,6 +150,7 @@ jobs:
- *CHECKOUT
- name: CI script
+ env: ${{ matrix.configuration.env_vars }}
uses: ./.github/actions/run-in-docker-action
with:
dockerfile: ./ci/linux-debian.Dockerfile
@@ -159,6 +162,11 @@ jobs:
runs-on: ubuntu-latest
needs: docker_cache
+ strategy:
+ matrix:
+ configuration:
+ - env_vars: {}
+
env:
WRAPPER_CMD: 'qemu-s390x'
SECP256K1_TEST_ITERS: 16
@@ -176,6 +184,7 @@ jobs:
- *CHECKOUT
- name: CI script
+ env: ${{ matrix.configuration.env_vars }}
uses: ./.github/actions/run-in-docker-action
with:
dockerfile: ./ci/linux-debian.Dockerfile
@@ -238,6 +247,8 @@ jobs:
strategy:
fail-fast: false
matrix:
+ configuration:
+ - env_vars: {}
cc:
- 'gcc'
- 'clang'
@@ -248,6 +259,7 @@ jobs:
- *CHECKOUT
- name: CI script
+ env: ${{ matrix.configuration.env_vars }}
uses: ./.github/actions/run-in-docker-action
with:
dockerfile: ./ci/linux-debian.Dockerfile
@@ -259,6 +271,11 @@ jobs:
runs-on: ubuntu-latest
needs: docker_cache
+ strategy:
+ matrix:
+ configuration:
+ - env_vars: {}
+
env:
WRAPPER_CMD: 'qemu-ppc64le'
SECP256K1_TEST_ITERS: 16
@@ -276,6 +293,7 @@ jobs:
- *CHECKOUT
- name: CI script
+ env: ${{ matrix.configuration.env_vars }}
uses: ./.github/actions/run-in-docker-action
with:
dockerfile: ./ci/linux-debian.Dockerfile
@@ -283,14 +301,14 @@ jobs:
- *PRINT_LOGS
valgrind_debian:
- name: "Valgrind ${{ matrix.binary_arch }} (memcheck)"
- runs-on: ${{ matrix.runner }}
+ name: "Valgrind ${{ matrix.configuration.binary_arch }} (memcheck)"
+ runs-on: ${{ matrix.configuration.runner }}
needs: docker_cache
strategy:
fail-fast: false
matrix:
- include:
+ configuration:
- runner: ubuntu-latest
binary_arch: x64
env_vars: { CC: 'clang', ASM: 'auto' }
@@ -327,7 +345,7 @@ jobs:
- *CHECKOUT
- name: CI script
- env: ${{ matrix.env_vars }}
+ env: ${{ matrix.configuration.env_vars }}
uses: ./.github/actions/run-in-docker-action
with:
dockerfile: ./ci/linux-debian.Dockerfile
@@ -640,6 +658,11 @@ jobs:
runs-on: ubuntu-latest
needs: docker_cache
+ strategy:
+ matrix:
+ configuration:
+ - env_vars: {}
+
env:
CC: 'g++'
CFLAGS: '-fpermissive -g'
@@ -656,6 +679,7 @@ jobs:
- *CHECKOUT
- name: CI script
+ env: ${{ matrix.configuration.env_vars }}
uses: ./.github/actions/run-in-docker-action
with:
dockerfile: ./ci/linux-debian.Dockerfile
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.