ci: add 'brew trust' invocation to macOS CI
What the developer wrote
Authored by fanquake
ci: add 'brew trust' invocation to macOS CI
Should fix issues like:
> Error: Refusing to load formula louisbrunner/valgrind/valgrind from untrusted tap louisbrunner/valgrind.
> Run `brew trust --formula louisbrunner/valgrind/valgrind` or `brew trust louisbrunner/valgrind` to trust it.
> Error: Process completed with exit code 1.
What changed, and why it matters
This commit is a routine fix to the project's automated macOS testing setup. Homebrew (a package manager for macOS) recently started refusing to load formulas from third-party sources unless explicitly trusted. The change simply tells Homebrew to trust the third-party tap that provides the Valgrind testing tool, so CI builds can continue. It does not change any cryptographic code, wallet handling, or network behavior in Bitcoin Core or libsecp256k1.
No security action required. This is a benign CI maintenance change. Reviewers may optionally verify that the LouisBrunner/valgrind tap remains the project's intended source for Valgrind on macOS CI.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch adds a single line to .github/actions/install-homebrew-valgrind/action.yml: brew trust --formula LouisBrunner/valgrind/valgrind. This is a CI-only configuration change that satisfies a new Homebrew security policy requiring explicit trust for third-party taps. It affects only the GitHub Actions workflow that installs Valgrind for macOS CI runs and does not touch secp256k1 source code, build scripts used by end users, or any runtime security logic.
Changed components
.github/actions/install-homebrew-valgrind/action.ymlInspect captured patch +1 / −0
diff --git a/.github/actions/install-homebrew-valgrind/action.yml b/.github/actions/install-homebrew-valgrind/action.yml
index e9aa615..c4e0b5d 100644
--- a/.github/actions/install-homebrew-valgrind/action.yml
+++ b/.github/actions/install-homebrew-valgrind/action.yml
@@ -5,6 +5,7 @@ runs:
steps:
- run: |
brew tap LouisBrunner/valgrind
+ brew trust --formula LouisBrunner/valgrind/valgrind
brew fetch --HEAD LouisBrunner/valgrind/valgrind
echo "CI_HOMEBREW_CELLAR_VALGRIND=$(brew --cellar valgrind)" >> "$GITHUB_ENV"
shell: bash
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.