What the developer wrote
Authored by Tads
feat(TinyScan): Remove grid from TinyScan #809
What changed, and why it matters
This commit removes the visual grid lines drawn on camera scans of TinySeed metal backup plates. It is a user-interface improvement to make the punched holes easier to see; it does not change security logic, cryptography, or data handling.
No security action required. Treat as a normal UI/UX improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes the TinyScanner._draw_grid() method and its single call site inside the scan loop. Previously, white grid lines were overlaid on the live camera image when scanning a TinySeed plate; now only the detected punch marks are drawn. The change is purely cosmetic and affects only the on-screen preview during scanning.
Changed components
src/krux/pages/tiny_seed.py (TinyScanner UI preview rendering)Inspect captured patch +5 / −19
diff --git a/CHANGELOG.md b/CHANGELOG.md
index d22c6af..e4080e3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,3 +1,8 @@
+# Changelog XX.XX.X
+
+### Other Bug Fixes and Improvements
+- Improve scan TinySeed and other binary visibility by drawing punches only
+
# Changelog 26.04.0 - April 2025
### Security Fixes
diff --git a/src/krux/pages/tiny_seed.py b/src/krux/pages/tiny_seed.py
index 8cbf29e..d32e6fc 100644
--- a/src/krux/pages/tiny_seed.py
+++ b/src/krux/pages/tiny_seed.py
@@ -633,24 +633,6 @@ class TinyScanner(Page):
img.draw_rectangle(outline, lcd.WHITE, thickness=thickness)
return rect
- def _draw_grid(self, img):
- if not kboard.has_minimal_display:
- for i in range(13):
- img.draw_line(
- self.x_regions[i],
- self.y_regions[0],
- self.x_regions[i],
- self.y_regions[-1],
- lcd.WHITE,
- )
- img.draw_line(
- self.x_regions[0],
- self.y_regions[i],
- self.x_regions[-1],
- self.y_regions[i],
- lcd.WHITE,
- )
-
def _detect_and_draw_punches(self, img):
"""Detect punched bits on the grid and update the seed numbers accordingly."""
page_seed_numbers = [0] * 12
@@ -811,7 +793,6 @@ class TinyScanner(Page):
self._gradient_corners(rect, img)
self._map_punches_region(rect, page)
page_seed_numbers = self._detect_and_draw_punches(img)
- self._draw_grid(img)
if kboard.is_m5stickv:
img.lens_corr(strength=1.0, zoom=0.56)
if kboard.is_amigo:
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.