CommitWatch RSS
AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 24 Bitcoin

XOR doesn’t display invalid mnemonic lengths for user selection (#747)

KXbfbdaec5 View source ↗
Public commit record

What the developer wrote

Authored by Tads

81/100 · Strong
XOR doesn’t display invalid mnemonic lengths for user selection (#747)

* XOR doesn’t display invalid mnemonic lengths for user selection

* XOR prompt msg now warns about passphrase

* XOR fix incorrect fingerprint displayed when using passphrase
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit fixes two user-facing bugs in Krux's 'mnemonic XOR' feature. First, when asking the user to pick a mnemonic length, it now only shows the length that matches the currently loaded wallet (12 or 24 words), preventing the user from accidentally selecting an incompatible length. Second, it now warns the user that the wallet passphrase and descriptor will be discarded before starting the XOR operation, and it corrects the fingerprint shown after the XOR so it no longer incorrectly includes the old passphrase. These are usability and correctness fixes rather than remote-exploitable security holes.

Recommended action

Review the change as a normal bug-fix/UX-hardening commit. No urgent security response is indicated, but downstream users should be aware that prior versions could display a misleading fingerprint during XOR when a passphrase was in use, and allowed selecting an incompatible mnemonic length.

Security signals we found

01

UI now restricts mnemonic-length selection to the length of the currently loaded key, reducing risk of user error during XOR

02

Prompt now explicitly warns that passphrase and descriptor will be discarded, improving informed consent

03

Fingerprint display bug fixed: XOR result fingerprint is now computed from the bare mnemonic instead of inheriting the previous wallet's passphrase

04

No evidence of memory corruption, remote code execution, or cryptographic weakness introduced

Risk score

Why this scored 24/100

Our methodology →
Potential impact 4/30
Exploitability 2/25
Stealth signal 3/15
Affected reach 5/15
Confidence 7/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

More from Krux

Related watches

Moderate 62 AI analysisMessage 90 · Strong
KX KruxKrux BitcoinHardware wallets

feat: warn when PSBT input amounts cannot be verified

This commit adds a warning screen to Krux, a hardware signing device, when it is asked to sign a multi-input Bitcoin transaction where the amounts of some inputs cannot be independently verified. The risk is that a malicious transaction co…

New user-facing warning for unverified multi-input SegWit amountsDetection logic tied to BIP143 signature semantics and inp.is_verifiedDoes not enforce previous-transaction inclusion; user can still proceed
518b3314by odudex+159−24 files
Vendor flagged security relevance
Open full analysis →Source commit ↗
Moderate 66 AI analysisMessage 85 · Strong
KX KruxKrux BitcoinHardware wallets

fix: reject a PSBT whose outputs exceed its inputs

This commit fixes a bug in Krux, a Bitcoin signing device, where a malformed transaction whose outputs spend more than its inputs could be loaded and shown to the user. Normally such a transaction is impossible on the Bitcoin network, but …

Input validation gap in PSBT parsingUI rendering bug masking invalid transaction economicsPotential social-engineering / user-confusion attack
d6813d88by odudex+52−02 files
Vendor flagged security relevance
Open full analysis →Source commit ↗
High 78 AI analysisMessage 95 · Strong
KX KruxKrux BitcoinHardware wallets

fix: verify PSBT input amounts before showing the fee

This commit fixes a security flaw in Krux, a Bitcoin signing device. Before the fix, an attacker could trick the device into showing a low transaction fee on screen while actually signing a much higher fee. The fix makes the device verify …

Fixes fee-display/sighash amount mismatchAdds prevout txid hash verification for non_witness_utxoMandates non_witness_utxo for legacy inputs
fc808059by odudex+353−122 files
Vendor flagged security relevance
Open full analysis →Source commit ↗