fix: long addresses having cropped final letters at addresses page (#837)
What the developer wrote
Authored by Odudex
fix: long addresses having cropped final letters at addresses page (#837)
What changed, and why it matters
This is a minor user-interface layout fix. In portrait mode, the screen was adding too little vertical space below a QR code before drawing a long text label (such as a Bitcoin address), causing the last letters of very long addresses to be cut off at the bottom edge. The change swaps a font-height spacing for a larger default padding so the full address remains visible. There is no security relevance in the commit itself.
No security action needed; treat as a normal UI/layout fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In src/krux/pages/qr_view.py, SeedQRView.draw_grided_qr’s portrait-mode branch computes y_offset for the centered label using self.ctx.display.qr_offset() + FONT_HEIGHT. The patch changes that to self.ctx.display.qr_offset() + DEFAULT_PADDING, increasing the gap between the QR code and the label so long addresses are not truncated. No cryptographic, input-validation, or trust-boundary changes are present.
Changed components
src/krux/pages/qr_view.pyInspect captured patch +1 / −1
diff --git a/src/krux/pages/qr_view.py b/src/krux/pages/qr_view.py
index 9abe9c1..879837a 100644
--- a/src/krux/pages/qr_view.py
+++ b/src/krux/pages/qr_view.py
@@ -530,7 +530,7 @@ class SeedQRView(Page):
self.draw_grided_qr(mode)
if self.ctx.display.height() > self.ctx.display.width():
- y_offset = self.ctx.display.qr_offset() + FONT_HEIGHT
+ y_offset = self.ctx.display.qr_offset() + DEFAULT_PADDING
self.ctx.display.draw_hcentered_text(
label,
y_offset,
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.