What the developer wrote
Authored by odudex
docs: add PSBT input amount fixes to CHANGELOG
What changed, and why it matters
This commit only updates the project's CHANGELOG.md to document earlier fixes related to PSBT (Partially Signed Bitcoin Transaction) fee and amount handling. It does not contain any code changes itself. The changelog entries describe security-relevant bugs where incorrect fee/amount calculations could be shown or confirmed during Bitcoin signing, which could trick a user into approving a bad transaction. However, because the actual fixes are not in this commit, we cannot inspect or verify them here.
Review the actual commits that implemented the PSBT fee/amount fixes and the negative-amount display fix to assess their completeness. Ensure stricter input validation, adequate coordinator data requirements, and user warnings are correctly implemented and tested before signing.
Security signals we found
Changelog documents prior PSBT fee/amount validation fixes
Mentions insufficient coordinator data as a security concern
No actual code or test changes in this commit
Cannot independently verify the described fixes from this diff alone
Evidence from the diff
The diff is a documentation-only addition to CHANGELOG.md under ‘Security Fixes’ and ‘Other Bug Fixes and Improvements’. It adds two PSBT-related security notes: stricter fee-calculation checks for on-screen display, and a warning when a wallet coordinator provides insufficient data to confirm input amounts. It also notes a fix for negative-amount display. No source code, tests, or functional changes are present in this commit.
Changed components
CHANGELOG.mdPSBT signing/fee display (referenced, not changed in this commit)Inspect captured patch +4 / −0
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 29f5542..c8efbc5 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,8 @@
### Security Fixes
- Camera entropy: fix a heap buffer overflow in the Shannon entropy module. Only the Maix Bit could trigger it, a device discontinued in 25.09.0 with no known users; every other device feeds the module a frame that fits. The module copied the whole frame into a fixed 320x240 RGB565 (153,600 byte) scratch buffer, so the Maix Bit's larger CIF frames (352x288 RGB565, 202,752 bytes) wrote 49,152 bytes past the end. The scratch copy has been removed entirely, the read length is now capped and rounded to whole pixels, and the CIF path is gone along with the Maix Bit
+- PSBT: stricter checks on the calculation of fee shown on screen
+- PSBT: warn before signing when the wallet coordinator did not send enough data to confirm those amounts
### Removed Maix Bit Code
All Maix Bit support has been removed from the source tree, including its firmware build project. Support for the device was discontinued in 25.09.0, which at the time kept the build parameters available; those are now gone too. The OV5642 sensor handling, used only by that device, was removed along with it.
@@ -12,8 +14,10 @@ Added vertical layout option for Stackbit 1248 backup display, allowing users to
### Migrate UR encoding to uUR C module
Switch from the pure-Python urtypes and foundation-ur-py packages to the new uUR C module, allowing faster UR QR codes decoding with a smaller RAM footprint. Tests and the simulator now build the same module for CPython instead of shimming the pure-Python packages, so host and device run identical UR code.
+
### Other Bug Fixes and Improvements
- Remove the unused `os.urandom()` from the MaixPy firmware. It was never called by Krux and played no part in generating keys or mnemonics, which draw entropy from the camera or dice. It was backed by a deterministic PRNG, so it has been removed to keep it from being mistaken for a secure source later
+- Fix display of negative amounts
- Improve scan TinySeed and other binary visibility by drawing punches only
- Added `flash_success` method to standardize green success flashes across confirmation screens
- Update Embit to latest - 3ae0ef2
Why this scored 63/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.