What the developer wrote
Authored by Odudex
screensaver bugfix: fix trigger condition (#761)
What changed, and why it matters
This is a one-line bugfix for a screensaver feature in the Krux firmware. The change makes the screensaver activate when the menu's top offset is at or below the status bar height, rather than only when it exactly equals the status bar height. Previously, the screensaver would not trigger in some legitimate idle situations, so this is a usability/reliability fix rather than a security issue.
No security action required. Treat as a normal functional bugfix. If reviewing for security, verify that the screensaver itself does not leak sensitive wallet information when active, but that is outside the scope of this diff.
Security signals we found
No security-relevant signals detected in the diff
Change is a relaxed equality comparison for a UI screensaver trigger
Evidence from the diff
The condition self.menu_offset == STATUS_BAR_HEIGHT is relaxed to self.menu_offset <= STATUS_BAR_HEIGHT. This broadens the trigger for the screensaver when no button is pressed (btn is None) and no info box is being drawn. The change appears intended to ensure the screensaver activates consistently when the UI is in a clean idle state. There is no evidence in the diff of a vulnerability, privilege escalation, information disclosure, or bypass.
Changed components
src/krux/pages/__init__.pyMenu class screensaver activation logicInspect captured patch +1 / −1
diff --git a/src/krux/pages/__init__.py b/src/krux/pages/__init__.py
index 79a7c45..9da6dc7 100644
--- a/src/krux/pages/__init__.py
+++ b/src/krux/pages/__init__.py
@@ -785,7 +785,7 @@ class Menu:
)
if isinstance(selected_item_index, tuple):
return selected_item_index
- elif btn is None and self.menu_offset == STATUS_BAR_HEIGHT:
+ elif btn is None and self.menu_offset <= STATUS_BAR_HEIGHT:
# Activates screensaver if there's no info_box(other things draw on the screen)
self.screensaver()
Why this scored 19/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.