fix: hide QR title in line/region modes to avoid index overlap
What the developer wrote
Authored by odudex
fix: hide QR title in line/region modes to avoid index overlap
What changed, and why it matters
This commit fixes a display bug in Krux, a Bitcoin hardware wallet tool. When showing QR codes in certain zoomed modes (line/region), a title text could overlap with on-screen index numbers, making the screen confusing. The fix simply hides the title in those modes. There is no direct evidence this is a security vulnerability.
Treat as a normal UI bug fix. No security response required unless further evidence shows the overlap could mislead users into scanning or transcribing incorrect QR data.
Security signals we found
UI overlap bug fixed
No security-relevant code paths modified
No input handling or cryptographic logic changed
Evidence from the diff
In SeedQRView, the code previously drew a centered title label whenever the display was taller than it was wide, regardless of QR viewing mode. In line/region modes, this title could overlap with grid index labels. The patch restricts title drawing to STANDARD_MODE and TRANSCRIBE_MODE only, preventing visual overlap. No cryptographic, input-validation, or access-control changes are present.
Changed components
src/krux/pages/qr_view.pySeedQRView UI renderingInspect captured patch +4 / −1
diff --git a/src/krux/pages/qr_view.py b/src/krux/pages/qr_view.py
index 6862697..73da118 100644
--- a/src/krux/pages/qr_view.py
+++ b/src/krux/pages/qr_view.py
@@ -529,7 +529,10 @@ class SeedQRView(Page):
self.qr_foreground = None
self.draw_grided_qr(mode)
- if self.ctx.display.height() > self.ctx.display.width():
+ if self.ctx.display.height() > self.ctx.display.width() and mode in (
+ STANDARD_MODE,
+ TRANSCRIBE_MODE,
+ ):
y_offset = self.ctx.display.qr_offset() + DEFAULT_PADDING
self.ctx.display.draw_hcentered_text(
label,
Why this scored 16/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.