What the developer wrote
Authored by ww3512687
fix ui bugs
What changed, and why it matters
This commit changes how wallet names are listed in the status bar for different product build variants (Web3, Cypherpunk, Bitcoin-only). It also adds a debug printf statement that prints a wallet name to the console. There is no clear security issue visible in the diff itself.
No immediate security action required. Treat as a normal UI/build fix. If desired, verify that the debug printf is acceptable for release builds and does not expose sensitive data in production logs.
Security signals we found
No direct security signal: change is build-variant UI configuration and a debug print statement.
Debug printf may leak wallet name to local serial/debug output, but this is not a remote disclosure and is common in embedded firmware.
Evidence from the diff
The patch refactors conditional compilation guards around the g_walletBtn array in src/ui/gui_components/gui_status_bar.c, replacing a single #ifndef BTC_ONLY / #else pair with separate #ifdef WEB3_VERSION, #ifdef CYPHERPUNK_VERSION, and #ifdef BTC_ONLY blocks. It also adds a printf() debug log inside SetWallet() when a matching wallet entry is found. The change appears to be a UI/build-configuration fix with no obvious memory corruption, injection, or cryptographic flaw in the modified code.
Changed components
src/ui/gui_components/gui_status_bar.cInspect captured patch +15 / −2
diff --git a/src/ui/gui_components/gui_status_bar.c b/src/ui/gui_components/gui_status_bar.c
index 014d0cf..5f3f21e 100644
--- a/src/ui/gui_components/gui_status_bar.c
+++ b/src/ui/gui_components/gui_status_bar.c
@@ -132,7 +132,7 @@ const static CoinWalletInfo_t g_coinWalletBtn[] = {
};
const static WalletInfo_t g_walletBtn[] = {
-#ifndef BTC_ONLY
+#ifdef WEB3_VERSION
{WALLET_LIST_KEYSTONE, "Keystone Nexus", &walletKeystone},
{WALLET_LIST_METAMASK, "MetaMask", &walletMetamask},
{WALLET_LIST_OKX, "OKX Wallet", &walletOkx},
@@ -174,7 +174,19 @@ const static WalletInfo_t g_walletBtn[] = {
{WALLET_LIST_FEATHER, "Feather Wallet", &walletFeather},
{WALLET_LIST_CORE, "Core Wallet", &walletCore},
{WALLET_LIST_IOTA, "IOTA Wallet", &walletIota},
-#else
+#endif
+
+#ifdef CYPHERPUNK_VERSION
+ {WALLET_LIST_BLUE, "Blue Wallet", &walletBluewallet},
+ {WALLET_LIST_SPARROW, "Sparrow", &walletSparrow},
+ {WALLET_LIST_UNISAT, "UniSat", &walletUniSat},
+ {WALLET_LIST_ZEUS, "Zeus Wallet", &walletZeus},
+ // {WALLET_LIST_CAKE, "Cake Wallet", &walletCake},
+ {WALLET_LIST_FEATHER, "Feather Wallet", &walletFeather},
+ {WALLET_LIST_ZASHI, "Zashi", &walletZashi},
+#endif
+
+#ifdef BTC_ONLY
{WALLET_LIST_BLUE, "BlueWallet", &walletBluewallet},
{WALLET_LIST_SPECTER, "Specter", &walletSpecter},
{WALLET_LIST_SPARROW, "Sparrow", &walletSparrow},
@@ -749,6 +761,7 @@ void SetWallet(NavBarWidget_t *navBarWidget, WALLET_LIST_INDEX_ENUM index, const
for (int i = 0; i < NUMBER_OF_ARRAYS(g_walletBtn); i++) {
if (g_walletBtn[i].index == index) {
coin = &g_walletBtn[i];
+ printf("wallet name: %s\n", coin->name);
break;
}
}
Why this scored 11/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.