What the developer wrote
Authored by soralit
chore: update ci
What changed, and why it matters
This commit is a routine build-system cleanup. It moves a Sui blockchain dependency from being declared in one specific app file to being declared once at the workspace level, and then references it from the app and C-binding crates. It also reformats some Zcash feature flags onto single lines. There is no visible security fix or vulnerability being patched.
No security action required; treat as normal CI/build maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff is purely a Cargo.toml/Cargo.lock refactor: sui-transaction-types-core is hoisted to the workspace root rust/Cargo.toml and referenced via workspace = true in rust/apps/sui/Cargo.toml and rust/rust_c/Cargo.toml. rust_c/Cargo.lock is updated accordingly. Additionally, multi-line Zcash feature flag arrays in rust/rust_c/Cargo.toml are collapsed to single-line arrays. No source code, cryptographic logic, or dependency version changes are present.
Changed components
rust/Cargo.tomlrust/Cargo.lockrust/apps/sui/Cargo.tomlrust/rust_c/Cargo.tomlInspect captured patch +8 / −14
diff --git a/rust/Cargo.lock b/rust/Cargo.lock
index 4f22c82..60824c1 100644
--- a/rust/Cargo.lock
+++ b/rust/Cargo.lock
@@ -3800,6 +3800,7 @@ dependencies = [
"serde_json",
"sha1",
"sim_qr_reader",
+ "sui-transaction-types-core",
"thiserror-core",
"ur-parse-lib",
"ur-registry",
diff --git a/rust/Cargo.toml b/rust/Cargo.toml
index f5311da..17b8782 100644
--- a/rust/Cargo.toml
+++ b/rust/Cargo.toml
@@ -76,6 +76,7 @@ rsa = { version = "0.8.2", default-features = false }
sha1 = { version = "0.10.5", default-features = false }
ur-registry = { git = "https://git@github.com/KeystoneHQ/keystone-sdk-rust.git", tag = "0.0.56" }
ur-parse-lib = { git = "https://git@github.com/KeystoneHQ/keystone-sdk-rust.git", tag = "0.0.56" }
+sui-transaction-types-core = { git = "https://github.com/KeystoneHQ/sui.git", tag = "mainnet-nostd-v1.69.2.1", default-features = false, features = ["alloc"] }
ed25519-bip32-core = { version = "0.1.1", default-features = false }
cryptoxide = "0.4"
arrayref = "0.3.6"
diff --git a/rust/apps/sui/Cargo.toml b/rust/apps/sui/Cargo.toml
index b1a9400..bc32972 100644
--- a/rust/apps/sui/Cargo.toml
+++ b/rust/apps/sui/Cargo.toml
@@ -8,7 +8,7 @@ edition = "2021"
[dependencies]
keystore = { workspace = true }
app_utils = { workspace = true }
-sui-transaction-types-core = { git = "https://github.com/KeystoneHQ/sui.git", tag = "mainnet-nostd-v1.69.2.1", default-features = false, features = ["alloc"] }
+sui-transaction-types-core = { workspace = true }
serde = { workspace = true }
serde_derive = { workspace = true }
bcs = { workspace = true }
diff --git a/rust/rust_c/Cargo.toml b/rust/rust_c/Cargo.toml
index 3cc294a..4d56b97 100644
--- a/rust/rust_c/Cargo.toml
+++ b/rust/rust_c/Cargo.toml
@@ -36,6 +36,7 @@ ed25519-bip32-core = { workspace = true }
app_utils = { workspace = true }
rust_tools = { workspace = true }
rand_core = { workspace = true }
+sui-transaction-types-core = { workspace = true }
zeroize = { workspace = true }
#apps
@@ -81,18 +82,9 @@ sui = ["dep:app_sui"]
ton = ["dep:app_ton"]
tron = ["dep:app_tron"]
xrp = ["dep:app_xrp"]
-zcash = [
- "dep:app_zcash",
- "dep:zcash_vendor",
-]
-zcash_multi_coins = [
- "zcash",
- "app_zcash/multi_coins",
-]
-zcash_cypherpunk = [
- "zcash",
- "app_zcash/cypherpunk",
-]
+zcash = ["dep:app_zcash", "dep:zcash_vendor"]
+zcash_multi_coins = ["zcash", "app_zcash/multi_coins"]
+zcash_cypherpunk = ["zcash", "app_zcash/cypherpunk"]
monero = ["dep:app_monero"]
avalanche = ["dep:app_avalanche"]
iota = ["dep:app_iota"]
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.