What the developer wrote
Authored by ww3512687
delete error code
What changed, and why it matters
This commit removes an unused C language label named 'out:' from a function in the RSA cryptography file. The label appears to have been leftover code with no actual security effect, because nothing in the function jumps to it and the cleanup logic runs unconditionally anyway. There is no indication this change fixes or introduces a security problem.
No security action required. Treat as routine code hygiene.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In src/crypto/rsa.c, the FlashReadRsaPrimes() function previously contained a bare ‘out:’ label. No goto, return, or other control-flow transfer referenced this label, and the following cleanup block (freeing encData) executes unconditionally after the do/while(0) block. The patch simply deletes the unused label. This is a code-cleanup change with no functional or security impact evident from the diff.
Changed components
src/crypto/rsa.cInspect captured patch +0 / −1
diff --git a/src/crypto/rsa.c b/src/crypto/rsa.c
index 54f517a..051a46c 100644
--- a/src/crypto/rsa.c
+++ b/src/crypto/rsa.c
@@ -78,7 +78,6 @@ Rsa_primes_t *FlashReadRsaPrimes(void)
ASSERT(HasMatchingPrimesHash(primes, hash));
} while (0);
-out:
if (encData) {
free_simple_response_u8(encData);
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.