CommitWatch RSS
AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
High 70 Bitcoin

fix: judge zcash internal address

KS3ff55913 View source ↗
Public commit record

What the developer wrote

Authored by soralit

57/100 · Thin
fix: judge zcash internal address
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes a Zcash transaction-checking bug in the Keystone 3 hardware wallet firmware. A maliciously crafted transaction could make an output look like the wallet's own change by using the wallet's internal viewing key, even though the money actually went to an attacker's address. The fix adds a check that any output decrypted with the internal key really belongs to the wallet, and adds a regression test that reproduces the attack scenario.

Recommended action

Treat this as a security fix and include it in the next firmware release. Review whether similar OVK/IVK confusion exists for Sapling outputs or other shielded protocols. Run the new regression test in CI and consider adding a test for the external-OVK case as well.

Security signals we found

01

Fixes incorrect change detection in Zcash Orchard shielded outputs

02

Adds validation that internal-OVK-decrypted outputs are actually wallet-owned

03

Includes regression test named test_parse_pczt_rejects_orchard_internal_ovk_change_spoofing

04

Adds zcash_primitives and pczt crates as dev-dependencies for test construction

05

No CVE, advisory, or vendor security disclosure present in commit or references

Risk score

Why this scored 70/100

Our methodology →
Potential impact 22/30
Exploitability 14/25
Stealth signal 12/15
Affected reach 10/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.

More from Keystone 3 firmware

Related watches

Low 42 AI analysisMessage 58 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge pull request #2293 from KeystoneHQ/merge/v3.1.0

This is a large firmware release merge (v3.1.0) for the Keystone 3 hardware wallet. The visible changes are mostly a major FreeRTOS kernel upgrade (from v10.x to v11.3.0), build-system improvements, and user-facing feature tweaks such as b…

FreeRTOS kernel major version upgrade (10.x -> 11.3.0) with MPU hardeningSwitch from ARM_CM4F non-MPU port to ARM_CM4_MPU portNew MPU configuration flags: configTOTAL_MPU_REGIONS=8, configENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY=1, configALLOW_UNPRIVILEGED_CRITICAL_SECTIONS=0
0c0ae467by stone+59616−26981300 files
Vendor flagged security relevance
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 48 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: update ci (#2292)

This commit only updates a Git submodule pointer in a release-tracking file. The actual code change is a one-line pointer update from one commit hash to another in a file named 'keystone3-firmware-release'. There is no visible security-rel…

90d1c789by Soralit+1−11 file
No security note in commit
Open full analysis →Source commit ↗
Informational 15 AI analysisMessage 40 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: update ci

This commit only updates a Git submodule pointer (keystone3-firmware-release) from one commit hash to another. No source code, build scripts, CI configuration, or security-related files are changed in the visible diff. There is no evidence…

a7f6db29by Soralit+1−11 file
No security note in commit
Open full analysis →Source commit ↗