AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
High 76 Bitcoin

Merge pull request #2262 from KeystoneHQ/regular-review-fix

Public commit record

What the developer wrote

Authored by Soralit

58/100 · Thin
Merge pull request #2262 from KeystoneHQ/regular-review-fix

fix: regular AI review and fix
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This firmware update fixes several security and safety issues found during a regular AI-assisted code review. The most important changes are: (1) Zcash wallet data is now encrypted with a key derived from the wallet seed and a fresh random IV, instead of being encrypted with a simple hash of the login password and a fixed seed-derived IV. (2) Ethereum legacy transactions now show a warning when they are not protected against replay attacks. (3) Solana transactions that contain hidden trailing bytes are now rejected before the user can review them. (4) Solana mixed transactions no longer hide unrelated instructions behind a specialized UI; sibling instructions are shown separately. (5) Tron transactions now reject multiple contracts, unsupported contract types, and ignore untrusted token metadata supplied by a host computer. (6) Cosmos delegate/undelegate/redelegate labels were corrected so users see the right addresses. (7) A new paginated message viewer helps users read long Ethereum messages before signing. The commit is described by the vendor as a 'regular AI review and fix' and does not explicitly call itself a security patch, but the changes clearly remove weaknesses that could mislead users or leak sensitive data.

Recommended action

Treat this as a security-relevant firmware update and ensure it is included in the next release. Users with Zcash enabled should be encouraged to update so that stored UFVK blobs are migrated to the new seed-derived-key + random-IV format. QA should verify that legacy Zcash blobs are regenerated on first unlock, that Ethereum legacy non-EIP-155 transactions show the replay warning, that Solana transactions with trailing bytes are rejected, and that mixed Solana transactions display all sibling instructions. The patch is broad and partially defensive, so a full regression of transaction parsing for Ethereum, Solana, Tron, Cosmos, and Zcash is warranted.

Security signals we found

01

Zcash UFVK encryption key changed from sha256(password) to seed-derived BIP32 key

02

Zcash UFVK IV changed from deterministic seed-derived value to fresh TRNG-generated IV per blob

03

Zcash UFVK storage format now uses magic-prefixed blob with embedded IV and rejects legacy blobs

04

Ethereum legacy transactions now expose replay_protected flag and warn when false

05

Solana parser no longer filters out sibling instructions for specialized display types

06

Solana check/parse paths reject malformed transactions with trailing bytes

07

Tron raw parser rejects multiple contracts and unsupported contract types

08

Tron payload parser ignores host-supplied token override metadata and falls back to local allowlist or raw units

09

Tron adds TRC-20 Approve decoding in addition to Transfer

010

Cosmos delegate/undelegate/redelegate labels corrected to Delegator/Validator/New Validator

011

New paginated message viewer for long Ethereum messages

Risk score

Why this scored 76/100

Our methodology →
Potential impact 24/30
Exploitability 18/25
Stealth signal 10/15
Affected reach 12/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.