AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 28 Bitcoin

Merge pull request #701 from Foundation-Devices/SFT-8161-use-bip39-generate

Public commit record

What the developer wrote

Authored by mjg-foundation

58/100 · Thin
Merge pull request #701 from Foundation-Devices/SFT-8161-use-bip39-generate

SFT-8161: honour USE_BIP39_GENERATE
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This commit removes the `bip39.generate()` function from the firmware's exposed programming interface when a build flag called `USE_BIP39_GENERATE` is set to 0. Passport already creates wallet seed phrases through a different internal path that uses its own noise/randomness source, so this change simply hides an unused function and adds a test to make sure it stays hidden. It is a defensive hardening change, not a fix for an active bug or exploit.

Recommended action

No immediate action required. Treat as routine hardening. Reviewers may want to confirm that no other code paths call `trezorcrypto.bip39.generate()` and that the build flag is consistently applied across release configurations.

Security signals we found

01

Reduction of firmware API surface for unused secret-generation function

02

Defensive build-time gating with preprocessor flag

03

Regression test verifying absence of a sensitive function

04

Documentation of randomness-source separation between routine crypto and seed generation

Risk score

Why this scored 28/100

Our methodology →
Potential impact 5/30
Exploitability 3/25
Stealth signal 4/15
Affected reach 5/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.