What changed, and why it matters
This commit removes the 'Home' tab from Feather Wallet and moves the Tickers plugin to live inside the 'Calc' tab instead. It is a user-interface cleanup change, not a security fix. There is no indication it addresses any vulnerability.
No security action required; treat as routine feature removal/refactoring.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch deletes the HomePlugin/HomeWidget implementation, removes the ‘Home’ entry from default enabled tabs, and makes the Tickers plugin a child of the Calc plugin. It also adds a parent-plugin dependency check in PluginRegistry and updates UI strings that previously mentioned ‘Home feeds’. No security-relevant code paths (cryptography, network parsing, wallet handling, permissions) are modified.
Changed components
src/plugins/home/* (removed)src/plugins/calc/CalcPluginsrc/plugins/tickers/TickersPluginsrc/plugins/PluginRegistry.hsrc/MainWindow.uisrc/utils/config.cppInspect captured patch +30 / −244
### CMakeLists.txt
@@ -31,9 +31,9 @@ option(STACK_TRACE "Dump stack trace on crash (Linux only)" OFF)
option(TOR_INSTALLED "Is Tor installed on the filesystem?" OFF)
# Plugins
-option(WITH_PLUGIN_HOME "Include Home tab plugin" ON)
-option(WITH_PLUGIN_TICKERS "Include Tickers Home plugin" ON)
+include(CMakeDependentOption)
option(WITH_PLUGIN_CALC "Include Calc tab plugin" ON)
+cmake_dependent_option(WITH_PLUGIN_TICKERS "Include Tickers plugin on the Calc tab" ON "WITH_PLUGIN_CALC" OFF)
list(INSERT CMAKE_MODULE_PATH 0 "${CMAKE_SOURCE_DIR}/cmake")
include(CheckCCompilerFlag)
### src/CMakeLists.txt
@@ -90,14 +90,14 @@ foreach (_var ${_vars})
if(_isPlugin)
string(REPLACE "${PLUGIN_PREFIX}" "" _suffix ${_var})
string(TOLOWER "${_suffix}" _plugin)
- message(STATUS "Adding plugin: ${_plugin}")
file (GLOB PLUGIN_FILES
"plugins/${_plugin}/*.cpp"
"plugins/${_plugin}/*.h"
)
- list (APPEND SOURCE_FILES
- ${PLUGIN_FILES}
- )
+ if(PLUGIN_FILES)
+ message(STATUS "Adding plugin: ${_plugin}")
+ list(APPEND SOURCE_FILES ${PLUGIN_FILES})
+ endif()
endif()
endforeach()
### src/MainWindow.cpp
@@ -660,8 +660,6 @@ void MainWindow::tryStoreWallet() {
}
void MainWindow::onWebsocketStatusChanged(bool enabled) {
- ui->actionShow_Home->setVisible(enabled);
-
QStringList enabledTabs = conf()->get(Config::enabledTabs).toStringList();
for (const auto &plugin : m_plugins) {
### src/MainWindow.ui
@@ -847,11 +847,6 @@
<string>Rescan spent</string>
</property>
</action>
- <action name="actionShow_Home">
- <property name="text">
- <string>Show Home</string>
- </property>
- </action>
<action name="actionWallet_cache_debug">
<property name="text">
<string>Wallet cache debug</string>
### src/SettingsDialog.ui
@@ -254,7 +254,7 @@
</sizepolicy>
</property>
<property name="text">
- <string><html><head/><body><p>Feather can connect to a service hosted by the developers to obtain pricing information, a curated list of remote nodes, Home feeds, the latest version of Feather Wallet and more.</p><p>This service is only used to fetch information. The wallet does not send information about its state or your transactions to the server. It is not used for any telemetry or crash reports.</p><p>If you disable this connection some functionality will be unavailable.</p></body></html></string>
+ <string><html><head/><body><p>Feather can connect to a service hosted by the developers to obtain pricing information, a curated list of remote nodes, the latest version of Feather Wallet and more.</p><p>This service is only used to fetch information. The wallet does not send information about its state or your transactions to the server. It is not used for any telemetry or crash reports.</p><p>If you disable this connection some functionality will be unavailable.</p></body></html></string>
</property>
<property name="wordWrap">
<bool>true</bool>
### src/plugins/PluginRegistry.h
@@ -47,6 +47,10 @@ class PluginRegistry {
return false;
}
+ if (plugin->hasParent() && !isPluginEnabled(plugin->parent())) {
+ return false;
+ }
+
QStringList enabledPlugins = conf()->get(Config::enabledPlugins).toStringList();
if (enabledPlugins.contains(id) && !plugin->implicitEnable()) {
return true;
### src/plugins/calc/CalcPlugin.cpp
@@ -51,6 +51,12 @@ QWidget* CalcPlugin::tab() {
return m_tab;
}
+void CalcPlugin::addSubPlugin(Plugin* plugin) {
+ if (plugin->type() == Plugin::WIDGET) {
+ m_tab->addWidget(plugin->tab());
+ }
+}
+
bool CalcPlugin::configurable() {
return true;
}
### src/plugins/calc/CalcPlugin.h
@@ -22,6 +22,7 @@ class CalcPlugin : public Plugin {
QStringList socketData() override;
PluginType type() override;
QWidget* tab() override;
+ void addSubPlugin(Plugin* plugin) override;
bool configurable() override;
QDialog* configDialog(QWidget *parent) override;
### src/plugins/calc/CalcWidget.cpp
@@ -54,6 +54,10 @@ CalcWidget::CalcWidget(QWidget *parent)
this->updateStatus();
}
+void CalcWidget::addWidget(QWidget *widget) {
+ ui->pluginLayout->addWidget(widget);
+}
+
void CalcWidget::convert(bool reverse) {
if (!m_comboBoxInit)
return;
@@ -167,4 +171,4 @@ void CalcWidget::updateStatus() {
}
}
-CalcWidget::~CalcWidget() = default;
\ No newline at end of file
+CalcWidget::~CalcWidget() = default;
### src/plugins/calc/CalcWidget.h
@@ -19,6 +19,7 @@ Q_OBJECT
public:
explicit CalcWidget(QWidget *parent = nullptr);
~CalcWidget() override;
+ void addWidget(QWidget *widget);
public slots:
void skinChanged();
### src/plugins/calc/CalcWidget.ui
@@ -14,6 +14,9 @@
<string>MainWindow</string>
</property>
<layout class="QVBoxLayout" name="verticalLayout_2">
+ <item>
+ <layout class="QVBoxLayout" name="pluginLayout"/>
+ </item>
<item>
<widget class="QFrame" name="frame_warning">
<property name="frameShape">
### src/plugins/home/HomePlugin.cpp
@@ -1,76 +0,0 @@
-// SPDX-License-Identifier: BSD-3-Clause
-// SPDX-FileCopyrightText: The Monero Project
-
-#include "HomePlugin.h"
-
-#include "plugins/PluginRegistry.h"
-
-HomePlugin::HomePlugin()
-{
-}
-
-void HomePlugin::initialize(Wallet *wallet, QObject *parent) {
- this->setParent(parent);
- m_tab = new HomeWidget(nullptr);
-}
-
-QString HomePlugin::id() {
- return "home";
-}
-
-int HomePlugin::idx() const {
- return 0;
-}
-
-QString HomePlugin::parent() {
- return "";
-}
-
-QString HomePlugin::displayName() {
- return "Home";
-}
-
-QString HomePlugin::description() {
- return {};
-}
-QString HomePlugin::icon() {
- return "tab_home.png";
-}
-
-QStringList HomePlugin::socketData() {
- return {};
-}
-
-Plugin::PluginType HomePlugin::type() {
- return Plugin::PluginType::TAB;
-}
-
-QWidget* HomePlugin::tab() {
- return m_tab;
-}
-
-void HomePlugin::addSubPlugin(Plugin* plugin) {
- m_tab->addPlugin(plugin);
-}
-
-bool HomePlugin::implicitEnable() {
- return true;
-}
-
-bool HomePlugin::insertFirst() {
- return true;
-}
-
-void HomePlugin::aboutToQuit() {
- m_tab->aboutToQuit();
-}
-
-void HomePlugin::uiSetup() {
- m_tab->uiSetup();
-}
-
-const bool HomePlugin::registered = [] {
- PluginRegistry::registerPlugin(HomePlugin::create());
- PluginRegistry::getInstance().registerPluginCreator(&HomePlugin::create);
- return true;
-}();
### src/plugins/home/HomePlugin.h
@@ -1,43 +0,0 @@
-// SPDX-License-Identifier: BSD-3-Clause
-// SPDX-FileCopyrightText: The Monero Project
-
-#ifndef HOMEPLUGIN_H
-#define HOMEPLUGIN_H
-
-#include "plugins/Plugin.h"
-#include "HomeWidget.h"
-
-class HomePlugin : public Plugin {
- Q_OBJECT
-
-public:
- explicit HomePlugin();
-
- QString id() override;
- int idx() const override;
- QString parent() override;
- QString displayName() override;
- QString description() override;
- QString icon() override;
- QStringList socketData() override;
- PluginType type() override;
- QWidget* tab() override;
- bool implicitEnable() override;
- bool insertFirst() override;
- void addSubPlugin(Plugin* plugin) override;
-
- void initialize(Wallet *wallet, QObject *parent) override;
-
- static HomePlugin* create() { return new HomePlugin(); }
-
-public slots:
- void aboutToQuit() override;
- void uiSetup() override;
-
-private:
- HomeWidget* m_tab = nullptr;
- static const bool registered;
-};
-
-
-#endif //HOMEPLUGIN_H
### src/plugins/home/HomeWidget.cpp
@@ -1,34 +0,0 @@
-// SPDX-License-Identifier: BSD-3-Clause
-// SPDX-FileCopyrightText: The Monero Project
-
-#include "HomeWidget.h"
-#include "ui_HomeWidget.h"
-
-#include "utils/config.h"
-
-HomeWidget::HomeWidget(QWidget *parent)
- : QWidget(parent)
- , ui(new Ui::HomeWidget)
-{
- ui->setupUi(this);
-}
-
-void HomeWidget::addPlugin(Plugin *plugin)
-{
- if (plugin->type() == Plugin::TAB) {
- ui->tabHomeWidget->addTab(plugin->tab(), plugin->displayName());
- }
- else if (plugin->type() == Plugin::WIDGET) {
- ui->widgetLayout->addWidget(plugin->tab());
- }
-}
-
-void HomeWidget::uiSetup() {
- ui->tabHomeWidget->setCurrentIndex(conf()->get(Config::homeWidget).toInt());
-}
-
-void HomeWidget::aboutToQuit() {
- conf()->set(Config::homeWidget, ui->tabHomeWidget->currentIndex());
-}
-
-HomeWidget::~HomeWidget() = default;
\ No newline at end of file
### src/plugins/home/HomeWidget.h
@@ -1,31 +0,0 @@
-// SPDX-License-Identifier: BSD-3-Clause
-// SPDX-FileCopyrightText: The Monero Project
-
-#ifndef HOMEWIDGET_H
-#define HOMEWIDGET_H
-
-#include <QWidget>
-
-#include "plugins/Plugin.h"
-
-namespace Ui {
- class HomeWidget;
-}
-
-class HomeWidget : public QWidget
-{
- Q_OBJECT
-
-public:
- explicit HomeWidget(QWidget *parent = nullptr);
- ~HomeWidget();
-
- void addPlugin(Plugin *plugin);
- void aboutToQuit();
- void uiSetup();
-
-private:
- QScopedPointer<Ui::HomeWidget> ui;
-};
-
-#endif //HOMEWIDGET_H
### src/plugins/home/HomeWidget.ui
@@ -1,40 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<ui version="4.0">
- <class>HomeWidget</class>
- <widget class="QWidget" name="HomeWidget">
- <property name="geometry">
- <rect>
- <x>0</x>
- <y>0</y>
- <width>743</width>
- <height>460</height>
- </rect>
- </property>
- <property name="windowTitle">
- <string>Form</string>
- </property>
- <layout class="QVBoxLayout" name="verticalLayout">
- <property name="topMargin">
- <number>5</number>
- </property>
- <property name="bottomMargin">
- <number>5</number>
- </property>
- <item>
- <layout class="QVBoxLayout" name="widgetLayout"/>
- </item>
- <item>
- <widget class="QTabWidget" name="tabHomeWidget">
- <property name="currentIndex">
- <number>-1</number>
- </property>
- <property name="documentMode">
- <bool>true</bool>
- </property>
- </widget>
- </item>
- </layout>
- </widget>
- <resources/>
- <connections/>
-</ui>
### src/plugins/tickers/TickersPlugin.cpp
@@ -25,7 +25,7 @@ int TickersPlugin::idx() const {
}
QString TickersPlugin::parent() {
- return "home";
+ return "calc";
}
QString TickersPlugin::displayName() {
### src/utils/config.cpp
@@ -27,7 +27,6 @@ static const QHash<Config::ConfigKey, ConfigDirective> configStrings = {
{Config::warnOnKiImport,{QS("warnOnKiImport"), true}},
{Config::logLevel,{QS("logLevel"), 0}},
- {Config::homeWidget,{QS("homeWidget"), "ccs"}},
{Config::donateBeg,{QS("donateBeg"), 1}},
{Config::showHistorySyncNotice, {QS("showHistorySyncNotice"), true}},
@@ -47,7 +46,7 @@ static const QHash<Config::ConfigKey, ConfigDirective> configStrings = {
{Config::useOnionNodes,{QS("useOnionNodes"), false}},
// Tabs
- {Config::enabledTabs, {QS("enabledTabs"), QStringList{"Home", "History", "Send", "Receive", "Calc"}}},
+ {Config::enabledTabs, {QS("enabledTabs"), QStringList{"History", "Send", "Receive", "Calc"}}},
{Config::showSearchbar,{QS("showSearchbar"), true}},
// History
### src/utils/config.h
@@ -26,7 +26,6 @@ class Config : public QObject
warnOnTestnet,
warnOnKiImport,
- homeWidget,
donateBeg,
showHistorySyncNotice,
### src/wizard/PageNetworkWebsocket.ui
@@ -30,7 +30,7 @@
<item>
<widget class="QLabel" name="label_2">
<property name="text">
- <string><html><head/><body><p>Feather can connect to a service hosted by the developers to obtain pricing information, a curated list of remote nodes, Home feeds, the latest version of Feather Wallet and more.</p><p>This service is only used to fetch information. The wallet does not send information about its state or your transactions to the server. It is not used for any telemetry or crash reports.</p><p>If you disable this connection some wallet functionality will be unavailable. You can re-enable it at any time.</p></body></html></string>
+ <string><html><head/><body><p>Feather can connect to a service hosted by the developers to obtain pricing information, a curated list of remote nodes, the latest version of Feather Wallet and more.</p><p>This service is only used to fetch information. The wallet does not send information about its state or your transactions to the server. It is not used for any telemetry or crash reports.</p><p>If you disable this connection some wallet functionality will be unavailable. You can re-enable it at any time.</p></body></html></string>
</property>
<property name="wordWrap">
<bool>true</bool>Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.