What changed, and why it matters
This commit changes where Feather Wallet's build system downloads the qrencode library from. It switches the download source from the original author's website to GitHub, updates the expected file name and cryptographic hash, and adds steps to regenerate the library's build configuration. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a build-maintenance change, possibly because the old download link stopped working.
Verify the new SHA-256 hash (5385bc1b8c2f20f3b91d258bf8ccc8cf62023935df2d2676b5b67049f31a049c) against an independently obtained copy of libqrencode v4.1.1 from the upstream GitHub repository. Confirm the GitHub tag is authentic and that the source contents match the previously used 4.1.1 release. Consider pinning to a verified commit or adding signature verification if upstream provides it. No immediate security patch appears necessary based solely on this commit.
Security signals we found
Source URL changed for dependency download
SHA-256 hash updated for renamed archive
Build tooling added (autoconf/automake/libtool) to support source archive without pre-generated configure
No version bump or vulnerability description in commit
Evidence from the diff
The patch updates contrib/depends/packages/qrencode.mk to download libqrencode from GitHub release tags rather than fukuchi.org, changes the archive naming convention (v4.1.1.tar.gz), updates the sha256 hash accordingly, and adds an autoreconf -fvi invocation before autoconf because GitHub archives do not ship pre-generated configure scripts. The Guix manifest is updated to include libtool, autoconf, and automake as build dependencies. The version remains 4.1.1, so this is not a version upgrade. No security-relevant code changes are present in the diff.
Changed components
contrib/depends/packages/qrencode.mkcontrib/guix/manifest.scmqrencode dependency build processInspect captured patch +8 / −3
### contrib/depends/packages/qrencode.mk
@@ -1,8 +1,9 @@
package=qrencode
$(package)_version=4.1.1
-$(package)_download_path=https://fukuchi.org/works/qrencode/
-$(package)_file_name=$(package)-$($(package)_version).tar.gz
-$(package)_sha256_hash=da448ed4f52aba6bcb0cd48cac0dd51b8692bccc4cd127431402fca6f8171e8e
+$(package)_download_path=https://github.com/fukuchi/libqrencode/archive/refs/tags/
+$(package)_download_file=v$($(package)_version).tar.gz
+$(package)_file_name=$(package)-v$($(package)_version).tar.gz
+$(package)_sha256_hash=5385bc1b8c2f20f3b91d258bf8ccc8cf62023935df2d2676b5b67049f31a049c
define $(package)_set_vars
$(package)_config_opts=--disable-shared --without-tools --without-tests --disable-sdltest
@@ -16,6 +17,7 @@ define $(package)_preprocess_cmds
endef
define $(package)_config_cmds
+ autoreconf -fvi && \
$($(package)_autoconf)
endef
### contrib/guix/manifest.scm
@@ -260,6 +260,9 @@ chain for " target " development."))
gcc-toolchain-15
(list gcc-toolchain-15 "static")
gnu-make
+ libtool
+ autoconf
+ automake
pkg-config
cmake-minimal
meson ; used to build libfuse, wayland, libXau, libxkbcommon in dependsWhy this scored 19/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.