What changed, and why it matters
This commit removes leftover unused code and build dependencies. It deletes a 'Donate to Feather' menu action, an unused 'MiningMode' enum, a 'DONATE_BEG' compile flag, and the 'osslsigncode' package from a CI workflow. There is no security-relevant change here—just housekeeping cleanup.
No security action needed. Treat as routine maintenance cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch is purely subtractive cleanup: (1) removes osslsigncode from the Guix CI apt install list; (2) drops the DONATE_BEG compile definition and its CMake handling; (3) removes the actionDonate_to_Feather UI action from MainWindow.ui; (4) removes the unused MiningMode enum from config.h. No functional logic, cryptographic code, network handling, or privilege boundaries are modified.
Changed components
.github/workflows/guix.ymlsrc/CMakeLists.txtsrc/MainWindow.uisrc/utils/config.hInspect captured patch +1 / −15
### .github/workflows/guix.yml
@@ -54,7 +54,7 @@ jobs:
path: contrib/depends/sources
key: sources-${{ hashFiles('contrib/depends/packages/*') }}
- name: install dependencies
- run: sudo apt update; sudo apt -y install git ca-certificates apparmor-utils osslsigncode
+ run: sudo apt update; sudo apt -y install git ca-certificates apparmor-utils
- name: apparmor workaround
# https://bugs.launchpad.net/ubuntu/+source/guix/+bug/2064115
run: |
### src/CMakeLists.txt
@@ -201,10 +201,6 @@ if(SELF_CONTAINED)
target_compile_definitions(feather PRIVATE SELF_CONTAINED=1)
endif()
-if(DONATE_BEG)
- target_compile_definitions(feather PRIVATE DONATE_BEG=1)
-endif()
-
if (CHECK_UPDATES)
target_compile_definitions(feather PRIVATE CHECK_UPDATES=1)
endif()
### src/MainWindow.ui
@@ -669,11 +669,6 @@
<string>Report bug</string>
</property>
</action>
- <action name="actionDonate_to_Feather">
- <property name="text">
- <string>Donate to Feather</string>
- </property>
- </action>
<action name="actionExport_CSV">
<property name="text">
<string>Export CSV</string>
### src/utils/config.h
@@ -153,11 +153,6 @@ class Config : public QObject
spendable
};
- enum MiningMode {
- Pool = 0,
- Solo
- };
-
enum Proxy {
None = 0,
Tor,Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.