What changed, and why it matters
This commit removes the automated Windows code-signing step from Feather Wallet's build pipeline. Code signing is what puts a trusted digital stamp on software so Windows can warn users if the file has been tampered with. Removing it does not create a direct vulnerability in the wallet itself, but it means future Windows releases may show stronger 'unknown publisher' warnings and users lose one way to verify that the downloaded executable came from the project. It also removes a potential attack surface in the CI/CD system where a stolen signing API token could be abused.
Treat this as a supply-chain hygiene change, not an active vulnerability. Verify whether the project moved signing to another workflow, runs it locally, or stopped signing Windows releases entirely. If signing was dropped without replacement, consider documenting the change in release notes and advising Windows users to verify hashes via an out-of-band channel. Rotate the SIGNPATH_API_KEY secret if it is no longer needed.
Security signals we found
Removal of Authenticode code-signing for Windows release artifacts
Discontinuation of SignPath integration and API secret usage in CI
Loss of tamper-evidence guarantee for Windows installer/executable artifacts produced by CI
No documented replacement signing process in commit or supplied references
Evidence from the diff
The patch deletes the ‘codesigning’ job from .github/workflows/guix.yml and the outputs that fed artifact IDs into it. Previously, Windows builds (x86_64-w64-mingw32 executable and installer) were submitted to SignPath via signpath/github-action-submit-signing-request@v1 using a SIGNPATH_API_KEY secret, then the Authenticode signature was extracted with osslsigncode. After this change, builds are uploaded as artifacts but not signed in CI. The commit message simply says ‘ci: remove codesigning’ and gives no security rationale or replacement plan.
Changed components
.github/workflows/guix.ymlWindows release executable artifact (x86_64-w64-mingw32)Windows release installer artifact (x86_64-w64-mingw32.installer)SignPath code-signing integrationInspect captured patch +0 / −51
diff --git a/.github/workflows/guix.yml b/.github/workflows/guix.yml
index 116f848..dce40b0 100644
--- a/.github/workflows/guix.yml
+++ b/.github/workflows/guix.yml
@@ -36,9 +36,6 @@ jobs:
- target: "x86_64-apple-darwin"
- target: "arm64-apple-darwin"
- outputs:
- WIN_INSTALLER_ARTIFACT_ID: ${{ steps.win-installer.outputs.WIN_INSTALLER_ARTIFACT_ID }}
- WIN_EXECUTABLE_ARTIFACT_ID: ${{ steps.win-executable.outputs.WIN_EXECUTABLE_ARTIFACT_ID }}
name: ${{ matrix.toolchain.target }}
steps:
- uses: actions/checkout@v5
@@ -106,12 +103,6 @@ jobs:
path: |
guix/guix-build-*/output/${{ matrix.toolchain.target }}/*
guix/guix-build-*/logs/${{ matrix.toolchain.target }}/*
- - if: ${{ matrix.toolchain.target == 'x86_64-w64-mingw32.installer' }}
- id: win-installer
- run: echo "WIN_INSTALLER_ARTIFACT_ID=${{ steps.upload-artifact.outputs.artifact-id }}" >> "$GITHUB_OUTPUT"
- - if: ${{ matrix.toolchain.target == 'x86_64-w64-mingw32' }}
- id: win-executable
- run: echo "WIN_EXECUTABLE_ARTIFACT_ID=${{ steps.upload-artifact.outputs.artifact-id }}" >> "$GITHUB_OUTPUT"
bundle-logs:
runs-on: ubuntu-24.04
@@ -129,45 +120,3 @@ jobs:
with:
name: "logs"
path: '**/logs/**'
-
- codesigning:
- runs-on: ubuntu-24.04
- needs: [build-guix, bundle-logs]
- if: startsWith(github.ref, 'refs/tags/') && contains(github.ref, '-rc')
- strategy:
- fail-fast: false
- matrix:
- toolchain:
- - target: "x86_64-w64-mingw32"
- - target: "x86_64-w64-mingw32.installer"
- steps:
- - name: install dependencies
- run: sudo apt update; sudo apt -y install osslsigncode
- - name: "set artifact id"
- run: |
- if [ "${{ matrix.toolchain.target }}" == "x86_64-w64-mingw32" ]; then
- echo "ARTIFACT_ID=${{ needs.build-guix.outputs.WIN_EXECUTABLE_ARTIFACT_ID }}" >> $GITHUB_ENV
- echo "ARTIFACT_SLUG=executable" >> $GITHUB_ENV
- elif [ "${{ matrix.toolchain.target }}" == "x86_64-w64-mingw32.installer" ]; then
- echo "ARTIFACT_ID=${{ needs.build-guix.outputs.WIN_INSTALLER_ARTIFACT_ID }}" >> $GITHUB_ENV
- echo "ARTIFACT_SLUG=installer" >> $GITHUB_ENV
- fi
- - uses: signpath/github-action-submit-signing-request@v1
- name: "request signature"
- with:
- api-token: '${{ secrets.SIGNPATH_API_KEY }}'
- organization-id: 'd3e94749-9c69-44e9-82de-c65cb3832869'
- project-slug: 'feather'
- signing-policy-slug: 'release-signing'
- artifact-configuration-slug: ${{ env.ARTIFACT_SLUG }}
- github-artifact-id: ${{ env.ARTIFACT_ID }}
- wait-for-completion: true
- output-artifact-directory: codesigning/
- - name: "extract signature"
- run: osslsigncode extract-signature -in codesigning/guix-build-*/output/${{ matrix.toolchain.target }}/*.exe -out codesigning/${{ matrix.toolchain.target }}.pem
- - uses: actions/upload-artifact@v7
- name: "upload signature"
- with:
- name: ${{ matrix.toolchain.target }}.pem
- path: |
- codesigning/${{ matrix.toolchain.target }}.pem
Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.