What changed, and why it matters
This commit adds a new step to the project's automated build process (CI) that signs and notarizes macOS releases using Apple developer certificates. It is a normal release-engineering change, not a vulnerability fix or malicious code change. However, it does introduce handling of sensitive signing secrets inside the build pipeline, which is a security-sensitive configuration worth reviewing.
Review how the signing secrets are managed: ensure GitHub secrets are scoped to the required environment, verify the pinned signapple commit, confirm temporary secret files are cleaned up after use, and audit artifact retention policies for detached signatures. No immediate patch is required for a vulnerability.
Security signals we found
CI pipeline now handles Apple code-signing secrets (MACOS_P12, MACOS_P8, MACOS_P12_PASSPHRASE, MACOS_NOTARIZE_API_KEY)
Third-party signing tool (achow101/signapple) is cloned and pinned to a specific commit
Secrets are written to temporary files on the runner during the build
New artifact upload exposes detached code signatures
Evidence from the diff
The commit modifies .github/workflows/guix.yml to add a ‘codesign macos’ job step that runs only for tagged releases targeting macOS (arm64-apple-darwin and x86_64-apple-darwin). It clones the third-party signapple tool at a pinned commit, installs dependencies via poetry, decodes hex-encoded PKCS#12 and AuthKey secrets into files, signs the Feather.app bundle with a hardened runtime, applies detached signatures, and notarizes via Apple’s notary service. The step then uploads detached code signatures as a build artifact. There is no code vulnerability in the diff itself; the change is a CI/release automation addition.
Changed components
.github/workflows/guix.ymlmacOS release build pipelineApple code signing and notarization processInspect captured patch +27 / −0
diff --git a/.github/workflows/guix.yml b/.github/workflows/guix.yml
index 50f3dfd..4b493d1 100644
--- a/.github/workflows/guix.yml
+++ b/.github/workflows/guix.yml
@@ -87,6 +87,26 @@ jobs:
/usr/local/bin/guix --version
- name: build
run: ADDITIONAL_GUIX_TIMEMACHINE_FLAGS="--disable-authentication" SUBSTITUTE_URLS='https://bordeaux.guix.gnu.org' GUIX_REPO='https://github.com/monero-project/guix.git' HOSTS="${{ matrix.toolchain.target }}" ./contrib/guix/guix-build
+
+ - name: codesign macos
+ if: startsWith(github.ref, 'refs/tags/') && (matrix.toolchain.target == 'arm64-apple-darwin' || matrix.toolchain.target == 'x86_64-apple-darwin') }}
+ run: |
+ sudo apt install -y python3-poetry xxd unzip
+ git clone https://github.com/achow101/signapple.git
+ cd signapple
+ git reset --hard 0c087854fd2822ab63512cbfa3b55706239b27c2
+ poetry install
+ echo "${{ secrets.MACOS_P12 }}" > p12.hex
+ xxd -r -p p12.hex p12
+ echo "${{ secrets.MACOS_P8 }}" > p8.hex
+ xxd -r -p p8.hex AuthKey_CC49BC72BA.p8
+ mkdir -p /tmp/codesign/detached
+ cp ../guix/guix-build-*/output/${{ matrix.toolchain.target }}/*.zip /tmp/codesign
+ unzip /tmp/codesign/*.zip -d /tmp/codesign
+ poetry run python codesign.py sign -f --passphrase="${{ secrets.MACOS_P12_PASSPHRASE }}" --detach /tmp/codesign/detached p12 /tmp/codesign/Feather.app --hardened-runtime
+ poetry run python codesign.py apply /tmp/codesign/Feather.app /tmp/codesign/detached/Feather.app
+ poetry run python codesign.py notarize --detach /tmp/codesign/detached --passphrase="" AuthKey_CC49BC72BA.p8 "${{ secrets.MACOS_NOTARIZE_API_KEY }}" /tmp/codesign/Feather.app
+
- uses: actions/upload-artifact@v7
id: upload-artifact
with:
@@ -95,6 +115,13 @@ jobs:
guix/guix-build-*/output/${{ matrix.toolchain.target }}/*
guix/guix-build-*/logs/${{ matrix.toolchain.target }}/*
+ - uses: actions/upload-artifact@v7
+ if: startsWith(github.ref, 'refs/tags/') && (matrix.toolchain.target == 'arm64-apple-darwin' || matrix.toolchain.target == 'x86_64-apple-darwin') }}
+ with:
+ name: ${{ matrix.toolchain.target }}-codesignatures
+ path: |
+ /tmp/codesign/detached/*
+
bundle-logs:
runs-on: ubuntu-24.04
needs: [build-guix]
Why this scored 12/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.