What changed, and why it matters
This commit simply removes an optional home-screen plugin called 'Revuo' (a Monero newsletter viewer) from the Feather Wallet application. It deletes the plugin's source files, build option, and default entry in the enabled-plugins list. There is no indication this is a security fix; it appears to be routine feature removal or cleanup.
No security action required. Treat as normal feature-removal commit. If maintaining a fork, verify that any remaining references to the revuo plugin or its websocket data type are cleaned up to avoid build or runtime warnings.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change removes the Revuo home plugin entirely: CMake option WITH_PLUGIN_REVUO is dropped, all src/plugins/revuo/* files are deleted, and the default enabledPlugins config no longer includes ‘revuo’. The plugin displayed newsletter content received over a websocket, rendered it in a QTextBrowser, and provided a donation link. No vulnerability is described or evident in the diff; the removal eliminates the associated code surface but does not patch a disclosed bug.
Changed components
Feather Wallet home tab plugin systemRevuo plugin (removed)Default configuration for enabled pluginsInspect captured patch +1 / −357
### CMakeLists.txt
@@ -34,7 +34,6 @@ option(TOR_INSTALLED "Is Tor installed on the filesystem?" OFF)
option(WITH_PLUGIN_HOME "Include Home tab plugin" ON)
option(WITH_PLUGIN_TICKERS "Include Tickers Home plugin" ON)
option(WITH_PLUGIN_CROWDFUNDING "Include Crowdfunding Home plugin" ON)
-option(WITH_PLUGIN_REVUO "Include Revuo Home plugin" ON)
option(WITH_PLUGIN_CALC "Include Calc tab plugin" ON)
list(INSERT CMAKE_MODULE_PATH 0 "${CMAKE_SOURCE_DIR}/cmake")
### src/plugins/revuo/RevuoItem.h
@@ -1,24 +0,0 @@
-// SPDX-License-Identifier: BSD-3-Clause
-// SPDX-FileCopyrightText: The Monero Project
-
-#ifndef FEATHER_REVUOITEM_H
-#define FEATHER_REVUOITEM_H
-
-#include <QString>
-#include <QStringList>
-
-struct RevuoItem : QObject
-{
- Q_OBJECT
-
-public:
- explicit RevuoItem(QObject *parent)
- : QObject(parent) {};
-
- QString title;
- QString url;
- QStringList newsbytes;
- QList<QPair<QString, QString>> events;
-};
-
-#endif //FEATHER_REVUOITEM_H
### src/plugins/revuo/RevuoPlugin.cpp
@@ -1,63 +0,0 @@
-// SPDX-License-Identifier: BSD-3-Clause
-// SPDX-FileCopyrightText: The Monero Project
-
-#include "RevuoPlugin.h"
-
-#include "plugins/PluginRegistry.h"
-#include "RevuoWidget.h"
-
-RevuoPlugin::RevuoPlugin()
-{
-}
-
-void RevuoPlugin::initialize(Wallet *wallet, QObject *parent) {
- this->setParent(parent);
- m_tab = new RevuoWidget(nullptr);
- connect(m_tab, &RevuoWidget::donate, this, &Plugin::fillSendTab);
-}
-
-QString RevuoPlugin::id() {
- return "revuo";
-}
-
-int RevuoPlugin::idx() const {
- return 40;
-}
-
-QString RevuoPlugin::parent() {
- return "home";
-}
-
-QString RevuoPlugin::displayName() {
- return "Revuo";
-}
-
-QString RevuoPlugin::description() {
- return {};
-}
-
-QString RevuoPlugin::icon() {
- return {};
-}
-
-QStringList RevuoPlugin::socketData() {
- return {"revuo"};
-}
-
-Plugin::PluginType RevuoPlugin::type() {
- return Plugin::PluginType::TAB;
-}
-
-QWidget* RevuoPlugin::tab() {
- return m_tab;
-}
-
-void RevuoPlugin::skinChanged() {
- m_tab->skinChanged();
-}
-
-const bool RevuoPlugin::registered = [] {
- PluginRegistry::registerPlugin(RevuoPlugin::create());
- PluginRegistry::getInstance().registerPluginCreator(&RevuoPlugin::create);
- return true;
-}();
### src/plugins/revuo/RevuoPlugin.h
@@ -1,38 +0,0 @@
-// SPDX-License-Identifier: BSD-3-Clause
-// SPDX-FileCopyrightText: The Monero Project
-
-#ifndef REVUOPLUGIN_H
-#define REVUOPLUGIN_H
-
-#include "plugins/Plugin.h"
-#include "RevuoWidget.h"
-
-class RevuoPlugin : public Plugin {
- Q_OBJECT
-
-public:
- explicit RevuoPlugin();
-
- QString id() override;
- int idx() const override;
- QString parent() override;
- QString displayName() override;
- QString description() override;
- QString icon() override;
- QStringList socketData() override;
- PluginType type() override;
- QWidget* tab() override;
-
- void initialize(Wallet *wallet, QObject *parent) override;
-
- static RevuoPlugin* create() { return new RevuoPlugin(); }
-
-public slots:
- void skinChanged() override;
-
-private:
- RevuoWidget* m_tab = nullptr;
- static const bool registered;
-};
-
-#endif //REVUOPLUGIN_H
### src/plugins/revuo/RevuoWidget.cpp
@@ -1,133 +0,0 @@
-// SPDX-License-Identifier: BSD-3-Clause
-// SPDX-FileCopyrightText: The Monero Project
-
-#include "RevuoWidget.h"
-#include "ui_RevuoWidget.h"
-
-#include <QJsonArray>
-
-#include "utils/ColorScheme.h"
-#include "Utils.h"
-#include "utils/Icons.h"
-#include "utils/WebsocketNotifier.h"
-
-RevuoWidget::RevuoWidget(QWidget *parent)
- : QWidget(parent)
- , ui(new Ui::RevuoWidget)
-{
- ui->setupUi(this);
-
- ui->textBrowser->setOpenLinks(false);
- ui->textBrowser->document()->setDefaultStyleSheet("a {color: white; }");
- ui->textBrowser->setText("<h4>No item selected</h4>");
- connect(ui->textBrowser, &QTextBrowser::anchorClicked, this, &RevuoWidget::onLinkActivated);
-
- ui->btn_openLink->setIcon(icons()->icon("external-link.svg"));
- connect(ui->btn_openLink, &QPushButton::clicked, this, &RevuoWidget::onOpenLink);
-
- connect(ui->combo_issue, &QComboBox::currentIndexChanged, this, &RevuoWidget::onSelectItem);
-
- connect(websocketNotifier(), &WebsocketNotifier::dataReceived, this, [this](const QString& type, const QJsonValue& json) {
- if (type == "revuo") {
- QJsonArray revuo_data = json.toArray();
- QList<QSharedPointer<RevuoItem>> l;
-
- for (const auto &entry: revuo_data) {
- auto obj = entry.toObject();
-
- QSharedPointer<RevuoItem> item = QSharedPointer<RevuoItem>(new RevuoItem(this));
-
- for (const auto &n : obj.value("newsbytes").toArray()) {
- item->newsbytes.append(n.toString());
- }
-
- for (const auto &e : obj.value("events").toArray()) {
- auto f = e.toObject();
- item->events.append({f.value("date").toString(), f.value("description").toString()});
- }
-
- item->title = obj.value("title").toString();
- item->url = obj.value("url").toString();
-
- l.append(item);
- }
-
- this->updateItems(l);
- }
- });
-}
-
-void RevuoWidget::updateItems(const QList<QSharedPointer<RevuoItem>> &items) {
- m_items.clear();
- m_links.clear();
- ui->combo_issue->clear();
-
- QStringList titles;
- for (const auto &item : items) {
- titles << item->title;
-
- QString text = "<h3>Recent News</h3>\n";
- for (const auto &newsbyte : item->newsbytes) {
- text += "<p> • " + newsbyte + "</p>\n";
- }
- text += "╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍╍\n";
- text += "<h3>Upcoming Events</h3>\n";
- if (item->events.isEmpty()) {
- text += "<p>There are no upcoming events.</p>\n";
- }
- for (const auto &event : item->events) {
- text += "<h4>" + event.first + "</h4>\n";
- text += "<p>" + event.second + "</p>\n";
- }
- text += "<hr>";
- text += QString("Read the whole issue in your <a href=\"%1\">browser</a>.").arg(item->url);
- text += "<br><br>\nEnjoy Revuo? Consider a <a href=\"feather://donate-revuo\">donation</a> to the author.";
-
- m_items.append(text);
- m_links.append(item->url);
- ui->combo_issue->addItem(item->title);
- }
-
- ui->combo_issue->setCurrentIndex(0);
-
-}
-
-void RevuoWidget::onSelectItem(int index) {
- if (index >= m_items.length() || index < 0) {
- ui->textBrowser->setText("<h4>No item selected</h4>");
- return;
- }
-
- ui->textBrowser->setText(m_items[index]);
-}
-
-void RevuoWidget::onLinkActivated(const QUrl &link) {
- if (link.host() == "donate-revuo") {
- this->onDonate();
- return;
- }
-
- Utils::externalLinkWarning(this, link.toString());
-}
-
-void RevuoWidget::onOpenLink() {
- int currentItem = ui->combo_issue->currentIndex();
- Utils::externalLinkWarning(this, m_links[currentItem]);
-}
-
-void RevuoWidget::onDonate() {
- emit donate("89Esx7ZAoVcD9wiDw57gxgS7m52sFEEbQiFC4qq18YZy3CdcsXvJ67FYdcDFbmYEGK7xerxgmDptd1C2xLstCbgF3RUhSMT", "Donation to Revuo Monero");
-}
-
-void RevuoWidget::skinChanged() {
- QString color = "black";
- if (ColorScheme::hasDarkBackground(this)) {
- color = "white";
- }
- auto stylesheet = QString("a {color: %1; }").arg(color);
-
- ui->textBrowser->document()->setDefaultStyleSheet(stylesheet);
- this->onSelectItem(0);
-}
-
-RevuoWidget::~RevuoWidget() = default;
### src/plugins/revuo/RevuoWidget.h
@@ -1,45 +0,0 @@
-// SPDX-License-Identifier: BSD-3-Clause
-// SPDX-FileCopyrightText: The Monero Project
-
-#ifndef FEATHER_REVUOWIDGET_H
-#define FEATHER_REVUOWIDGET_H
-
-#include <QWidget>
-#include <QMenu>
-
-#include "RevuoItem.h"
-
-namespace Ui {
- class RevuoWidget;
-}
-
-class RevuoWidget : public QWidget
-{
- Q_OBJECT
-
-public:
- explicit RevuoWidget(QWidget *parent = nullptr);
- ~RevuoWidget();
-
-signals:
- void donate(const QString &address, const QString &description);
-
-public slots:
- void updateItems(const QList<QSharedPointer<RevuoItem>>& items);
- void skinChanged();
-
-private slots:
- void onLinkActivated(const QUrl &link);
- void onSelectItem(int index);
- void onOpenLink();
- void onDonate();
-
-private:
- QScopedPointer<Ui::RevuoWidget> ui;
-
- QStringList m_items;
- QStringList m_links;
-};
-
-
-#endif //FEATHER_REVUOWIDGET_H
### src/plugins/revuo/RevuoWidget.ui
@@ -1,52 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<ui version="4.0">
- <class>RevuoWidget</class>
- <widget class="QWidget" name="RevuoWidget">
- <property name="geometry">
- <rect>
- <x>0</x>
- <y>0</y>
- <width>945</width>
- <height>508</height>
- </rect>
- </property>
- <property name="windowTitle">
- <string>Form</string>
- </property>
- <layout class="QHBoxLayout" name="horizontalLayout">
- <item>
- <layout class="QVBoxLayout" name="verticalLayout">
- <item>
- <layout class="QHBoxLayout" name="horizontalLayout_2">
- <item>
- <widget class="QComboBox" name="combo_issue"/>
- </item>
- <item>
- <widget class="QPushButton" name="btn_openLink">
- <property name="sizePolicy">
- <sizepolicy hsizetype="Maximum" vsizetype="Fixed">
- <horstretch>0</horstretch>
- <verstretch>0</verstretch>
- </sizepolicy>
- </property>
- <property name="text">
- <string/>
- </property>
- </widget>
- </item>
- </layout>
- </item>
- <item>
- <widget class="QTextBrowser" name="textBrowser">
- <property name="html">
- <string></string>
- </property>
- </widget>
- </item>
- </layout>
- </item>
- </layout>
- </widget>
- <resources/>
- <connections/>
-</ui>
### src/utils/config.cpp
@@ -123,7 +123,7 @@ static const QHash<Config::ConfigKey, ConfigDirective> configStrings = {
{Config::useLocalTor, {QS("useLocalTor"), false}},
{Config::initSyncThreshold, {QS("initSyncThreshold"), 360}},
- {Config::enabledPlugins, {QS("enabledPlugins"), QStringList{"tickers", "crowdfunding", "revuo", "calc"}}},
+ {Config::enabledPlugins, {QS("enabledPlugins"), QStringList{"tickers", "crowdfunding", "calc"}}},
{Config::restartRequired, {QS("restartRequired"), false}},
{Config::tickers, {QS("tickers"), QStringList{"XMR", "BTC", "XMR/BTC"}}},Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.