AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 34 Monero

Wallet: clear tmpTxDescription in sweepOutputs

Public commit record

What the developer wrote

Authored by monerobull

76/100 · Adequate
Wallet: clear tmpTxDescription in sweepOutputs

sweepOutputs never cleared tmpTxDescription before building a transaction,
so the confirmation dialog and commitTransaction would reuse the description
from the previous regular transaction. Mirror what createTransaction and
createTransactionMultiDest already do.

Fixes #299
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This fix corrects a bug in Feather Wallet's 'sweep outputs' feature. When a user swept funds (moved specific outputs), the wallet accidentally reused the payment description/memo from the previous regular transaction. This could mislead the user into confirming a transaction with the wrong description attached, and the incorrect description would be recorded in the transaction history. It is a UI/state bug rather than a code-execution vulnerability.

Recommended action

Apply the patch. After patching, verify that sweepOutputs clears the transaction description field in the confirmation dialog and that no description from a prior transaction is carried over. Consider adding a regression test for description state reset across transaction-building methods.

Security signals we found

01

State variable not reset between operations (stale tmpTxDescription)

02

UI confirmation dialog may display stale/misleading transaction description

03

Transaction metadata (description) may be incorrectly committed to wallet history

04

Fix mirrors existing pattern in createTransaction/createTransactionMultiDest

05

Fixes reported issue #299

Risk score

Why this scored 34/100

Our methodology →
Potential impact 8/30
Exploitability 3/25
Stealth signal 6/15
Affected reach 5/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.