What changed, and why it matters
This commit removes the fiat-denominated value column from the transaction history view in Feather Wallet. It deletes the code that looked up historical exchange rates, converted amounts, and displayed them as a 'Fiat' column. There is no security fix here; it is a feature-removal change.
No security action required. Treat as ordinary feature removal; review user-facing release notes if the fiat column deprecation affects support or compliance documentation.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch removes TransactionHistoryModel::FiatAmount, the associated data() handling, header label, column visibility wiring, and the setWebsocketEnabled plumbing that toggled the column. It also removes the conversion logic that used appData()->txFiatHistory and appData()->prices. No input validation, cryptography, network, or privilege logic is modified.
Changed components
src/HistoryWidget.cppsrc/HistoryWidget.hsrc/MainWindow.cppsrc/model/HistoryView.cppsrc/model/TransactionHistoryModel.cppsrc/model/TransactionHistoryModel.hInspect captured patch +0 / −35
diff --git a/src/HistoryWidget.cpp b/src/HistoryWidget.cpp
index 6f2433b..505dc6d 100644
--- a/src/HistoryWidget.cpp
+++ b/src/HistoryWidget.cpp
@@ -74,10 +74,6 @@ void HistoryWidget::focusSearchbar() {
ui->search->setFocus();
}
-void HistoryWidget::setWebsocketEnabled(bool enabled) {
- ui->history->setColumnHidden(TransactionHistoryModel::FiatAmount, !enabled);
-}
-
void HistoryWidget::showContextMenu(const QPoint &point) {
QModelIndex index = ui->history->indexAt(point);
if (!index.isValid()) {
diff --git a/src/HistoryWidget.h b/src/HistoryWidget.h
index d9d9826..07c94f8 100644
--- a/src/HistoryWidget.h
+++ b/src/HistoryWidget.h
@@ -24,7 +24,6 @@ public:
void setSearchbarVisible(bool visible);
void focusSearchbar();
- void setWebsocketEnabled(bool enabled);
public slots:
void setSearchText(const QString &text);
diff --git a/src/MainWindow.cpp b/src/MainWindow.cpp
index 6a2d6b8..309b9a5 100644
--- a/src/MainWindow.cpp
+++ b/src/MainWindow.cpp
@@ -675,7 +675,6 @@ void MainWindow::onWebsocketStatusChanged(bool enabled) {
}
}
- m_historyWidget->setWebsocketEnabled(enabled);
m_sendWidget->setWebsocketEnabled(enabled);
}
diff --git a/src/model/HistoryView.cpp b/src/model/HistoryView.cpp
index c982097..9d001cc 100644
--- a/src/model/HistoryView.cpp
+++ b/src/model/HistoryView.cpp
@@ -189,7 +189,6 @@ void HistoryView::resetViewToDefaults()
header()->showSection(TransactionHistoryModel::Date);
header()->showSection(TransactionHistoryModel::Description);
header()->showSection(TransactionHistoryModel::Amount);
- header()->showSection(TransactionHistoryModel::FiatAmount);
// Reset column order to logical indices
for (int i = 0; i < header()->count(); ++i) {
diff --git a/src/model/TransactionHistoryModel.cpp b/src/model/TransactionHistoryModel.cpp
index 1a0622d..afde8fc 100644
--- a/src/model/TransactionHistoryModel.cpp
+++ b/src/model/TransactionHistoryModel.cpp
@@ -63,7 +63,6 @@ QVariant TransactionHistoryModel::data(const QModelIndex &index, int role) const
else if (role == Qt::TextAlignmentRole) {
switch (index.column()) {
case Column::Amount:
- case Column::FiatAmount:
return Qt::AlignRight;
}
}
@@ -105,7 +104,6 @@ QVariant TransactionHistoryModel::data(const QModelIndex &index, int role) const
}
else if (role == Qt::ForegroundRole) {
switch(index.column()) {
- case Column::FiatAmount:
case Column::Amount:
{
if (tInfo.balanceDelta < 0) {
@@ -158,29 +156,6 @@ QVariant TransactionHistoryModel::parseTransactionInfo(const TransactionRow &tIn
}
return Utils::displayAddress(tInfo.hash, 1);
}
- case Column::FiatAmount:
- {
- double usd_price = appData()->txFiatHistory->get(tInfo.timestamp.toString("yyyyMMdd"));
- if (usd_price == 0.0) {
- return QString("?");
- }
-
- double usd_amount = usd_price * (abs(tInfo.balanceDelta) / constants::cdiv);
-
- QString preferredFiatCurrency = conf()->get(Config::preferredFiatCurrency).toString();
- if (preferredFiatCurrency != "USD") {
- usd_amount = appData()->prices.convert("USD", preferredFiatCurrency, usd_amount);
- }
- if (role == Qt::UserRole) {
- return usd_amount;
- }
- if (usd_amount == 0.0) {
- return QString("?");
- }
-
- double fiat_rounded = ceil(Utils::roundSignificant(usd_amount, 3) * 100.0) / 100.0;
- return QString("%1").arg(Utils::amountToCurrencyString(fiat_rounded, preferredFiatCurrency));
- }
default:
{
qCritical() << "Unimplemented role";
@@ -204,8 +179,6 @@ QVariant TransactionHistoryModel::headerData(int section, Qt::Orientation orient
return QString("Amount");
case Column::TxID:
return QString("Txid");
- case Column::FiatAmount:
- return QString("Fiat");
default:
return QVariant();
}
diff --git a/src/model/TransactionHistoryModel.h b/src/model/TransactionHistoryModel.h
index f2e3379..a6f5791 100644
--- a/src/model/TransactionHistoryModel.h
+++ b/src/model/TransactionHistoryModel.h
@@ -25,7 +25,6 @@ public:
TxID,
Description,
Amount,
- FiatAmount,
COUNT
};
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.