What changed, and why it matters
This commit removes the use of osslsigncode, a tool that attaches digital signatures to Windows executables, from Feather Wallet's Guix build scripts. It also removes the osslsigncode package from the build environment manifest. The change means Windows release binaries will no longer have Authenticode-style signatures attached during this automated build step. There is no direct evidence in the commit or supplied references that this is a security vulnerability fix; it appears to be a build/packaging change.
Treat as a build-system change, not a security patch. If Windows Authenticode signing is still required for releases, verify whether signing has been moved to a separate post-build step or replaced with another signing mechanism before release. If no replacement exists, release binaries may trigger Windows SmartScreen warnings; consider documenting the change for users.
Security signals we found
Removal of code-signing tooling from build pipeline
Windows release binaries will no longer carry Authenticode signatures from this build step
No vulnerability description, CVE, or security advisory referenced in commit
Evidence from the diff
The patch deletes code in contrib/guix/libexec/build.sh that used osslsigncode attach-signature to apply pre-existing Windows code-signing signatures (feather.pem / feather.installer.pem) to feather.exe and FeatherWalletSetup.exe. It also removes the osslsigncode package from contrib/guix/manifest.scm. The remaining logic still produces zip archives and installer outputs, but no longer attaches Authenticode signatures. The commit message simply says ‘guix: remove osslsigncode’ and provides no security rationale.
Changed components
contrib/guix/libexec/build.shcontrib/guix/manifest.scmWindows release build code-signing stepInspect captured patch +19 / −60
diff --git a/contrib/guix/libexec/build.sh b/contrib/guix/libexec/build.sh
index 7383d5c..a799412 100755
--- a/contrib/guix/libexec/build.sh
+++ b/contrib/guix/libexec/build.sh
@@ -416,69 +416,29 @@ export PATH="${BASEPREFIX}/${HOST}/native/bin:${PATH}"
;;
esac
- # Code-signing
- if [[ -n "${TAG}" ]]; then
- if [[ "${TAG}" != *"-rc"* ]]; then
- case "$HOST" in
- *darwin*)
- signapple apply Feather.app "/distsrc/external/feather-codesigning/signatures/${HOST}/Feather.app"
- ;;
- *mingw*)
- case "$OPTIONS" in
- installer)
- osslsigncode attach-signature \
- -in "FeatherWalletSetup.exe" \
- -out "FeatherWalletSetup.exe.tmp" \
- -CAfile "$GUIX_ENVIRONMENT/etc/ssl/certs/ca-certificates.crt" \
- -sigin "/distsrc/external/feather-codesigning/signatures/${HOST}/feather.installer.pem" || true
- cp FeatherWalletSetup.exe.tmp "${OUTDIR}/FeatherWalletSetup-${TAG}.exe"
- mv FeatherWalletSetup.exe.tmp "FeatherWalletSetup-${TAG}.exe"
- rm FeatherWalletSetup.exe
- rm "${OUTDIR}/FeatherWalletSetup.exe"
- ;;
- "")
- osslsigncode attach-signature \
- -in "feather.exe" \
- -out "feather.exe.tmp" \
- -CAfile "$GUIX_ENVIRONMENT/etc/ssl/certs/ca-certificates.crt" \
- -sigin "/distsrc/external/feather-codesigning/signatures/${HOST}/feather.pem" || true
- mv feather.exe.tmp feather.exe
- ;;
- esac
- ;;
- esac
- fi
- fi
-
# Finally, deterministically produce {non-,}debug binary tarballs ready
# for release
case "$HOST" in
*mingw*)
- if [[ "${TAG}" == *"-rc"* ]]; then
- if [ -z "$OPTIONS" ]; then
- mv feather.exe "${OUTDIR}/${DISTNAME}.exe"
- fi
- else
- case "$OPTIONS" in
- installer)
- find . -print0 \
- | xargs -0r touch --no-dereference --date="@${SOURCE_DATE_EPOCH}"
- find . \
- | sort \
- | zip -X@ "${OUTDIR}/${DISTNAME}-win-installer.zip" \
- || ( rm -f "${OUTDIR}/${DISTNAME}-win-installer.zip" && exit 1 )
- ;;
- "")
- mv feather.exe ${DISTNAME}.exe && \
- find . -print0 \
- | xargs -0r touch --no-dereference --date="@${SOURCE_DATE_EPOCH}"
- find . \
- | sort \
- | zip -X@ "${OUTDIR}/${DISTNAME}-win.zip" \
- || ( rm -f "${OUTDIR}/${DISTNAME}-win.zip" && exit 1 )
- ;;
- esac
- fi
+ case "$OPTIONS" in
+ installer)
+ find . -print0 \
+ | xargs -0r touch --no-dereference --date="@${SOURCE_DATE_EPOCH}"
+ find . \
+ | sort \
+ | zip -X@ "${OUTDIR}/${DISTNAME}-win-installer.zip" \
+ || ( rm -f "${OUTDIR}/${DISTNAME}-win-installer.zip" && exit 1 )
+ ;;
+ "")
+ mv feather.exe ${DISTNAME}.exe && \
+ find . -print0 \
+ | xargs -0r touch --no-dereference --date="@${SOURCE_DATE_EPOCH}"
+ find . \
+ | sort \
+ | zip -X@ "${OUTDIR}/${DISTNAME}-win.zip" \
+ || ( rm -f "${OUTDIR}/${DISTNAME}-win.zip" && exit 1 )
+ ;;
+ esac
;;
*linux*)
if [ "$OPTIONS" != "pack" ]; then
diff --git a/contrib/guix/manifest.scm b/contrib/guix/manifest.scm
index 806d504..868bba2 100644
--- a/contrib/guix/manifest.scm
+++ b/contrib/guix/manifest.scm
@@ -305,7 +305,6 @@ thus should be able to compile on most platforms where these exist.")
(make-mingw-pthreads-cross-toolchain "x86_64-w64-mingw32")
nsis-x86_64 ;; used to build the installer
nss-certs
- osslsigncode
gettext-minimal ;; used to build libgpg-error in depends
))
((string-contains target "-linux-")
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.