Merge pull request #304 from jpk68/hide-passphrase
What changed, and why it matters
This change adds a simple 'Hide passphrase' checkbox to the wallet setup wizard. By default, the optional seed passphrase is now masked with dots instead of being shown in plain text, which helps prevent someone nearby from reading it over the user's shoulder. It is a routine usability and privacy improvement, not a fix for a software vulnerability.
No security response required. Treat as a normal privacy/usability enhancement and review as part of routine QA.
Security signals we found
UI field now masks sensitive user input by default
No memory handling, cryptographic, or privilege changes present
No input validation, parsing, or network code modified
Evidence from the diff
The commit modifies the seed passphrase page in Feather Wallet’s wizard. It sets the QLineEdit echoMode to Password by default and adds a QCheckBox that toggles between Password and Normal echo modes. Previously the passphrase was displayed in plain text. This is a defense-in-depth shoulder-surfing mitigation with no cryptographic or access-control changes.
Changed components
src/wizard/PageSetSeedPassphrase.cppsrc/wizard/PageSetSeedPassphrase.uiInspect captured patch +23 / −1
### src/wizard/PageSetSeedPassphrase.cpp
@@ -5,6 +5,8 @@
#include "ui_PageSetSeedPassphrase.h"
#include "WalletWizard.h"
+#include <QCheckBox>
+
PageSetSeedPassphrase::PageSetSeedPassphrase(WizardFields *fields, QWidget *parent)
: QWizardPage(parent)
, ui(new Ui::PageSetSeedPassphrase)
@@ -13,10 +15,16 @@ PageSetSeedPassphrase::PageSetSeedPassphrase(WizardFields *fields, QWidget *pare
ui->setupUi(this);
this->setTitle("Seed Passphrase");
+
+ connect(ui->check_hidePassphrase, &QCheckBox::clicked, [this](bool checked){
+ ui->linePassphrase->setEchoMode(checked ? QLineEdit::Password : QLineEdit::Normal);
+ });
}
void PageSetSeedPassphrase::initializePage() {
ui->linePassphrase->setText("");
+ ui->check_hidePassphrase->setChecked(true);
+ ui->linePassphrase->setEchoMode(QLineEdit::Password);
}
bool PageSetSeedPassphrase::validatePage() {
### src/wizard/PageSetSeedPassphrase.ui
@@ -45,7 +45,21 @@
</widget>
</item>
<item>
- <widget class="QLineEdit" name="linePassphrase"/>
+ <widget class="QLineEdit" name="linePassphrase">
+ <property name="echoMode">
+ <enum>QLineEdit::Password</enum>
+ </property>
+ </widget>
+ </item>
+ <item>
+ <widget class="QCheckBox" name="check_hidePassphrase">
+ <property name="text">
+ <string>Hide passphrase</string>
+ </property>
+ <property name="checked">
+ <bool>true</bool>
+ </property>
+ </widget>
</item>
<item>
<widget class="QLabel" name="label_4">Why this scored 23/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.