What the developer wrote
Authored by SomberNight
ci: llm sec review: tweak trigger types
looks like if there is an overlap between automatic and manual, manual wins
What changed, and why it matters
This commit adjusts a CI (continuous integration) configuration so that an automated LLM security-review task is triggered automatically only for users with write or admin permissions, while a manual trigger is used for everyone else. It is a workflow tweak with no direct effect on Electrum's wallet code, cryptography, or user-facing security.
No security action required; this is a CI configuration refinement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change modifies .cirrus.yml trigger conditions for an LLM security review task. Previously, both automatic and manual triggers could match for users with write/admin permissions on a pull request, and Cirrus CI apparently prefers manual when both overlap. The patch narrows the manual trigger’s only_if condition to exclude write/admin users, ensuring the automatic trigger runs for privileged users and the manual trigger runs for others. This is a CI pipeline logic fix, not a product security patch.
Changed components
.cirrus.ymlInspect captured patch +1 / −1
diff --git a/.cirrus.yml b/.cirrus.yml
index 9b7ddcc..976d573 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -251,7 +251,7 @@ task:
- trigger_type: automatic
only_if: $CIRRUS_PR != '' && ($CIRRUS_USER_PERMISSION == 'write' || $CIRRUS_USER_PERMISSION == 'admin')
- trigger_type: manual
- only_if: $CIRRUS_PR != ''
+ only_if: $CIRRUS_PR != '' && !($CIRRUS_USER_PERMISSION == 'write' || $CIRRUS_USER_PERMISSION == 'admin')
container:
image: node:20
cpu: 1
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.