ci: appimage build: run build.sh directly instead of sub-scripts
What the developer wrote
Authored by SomberNight
ci: appimage build: run build.sh directly instead of sub-scripts
- previously we had the CI spawn us inside a docker container as per our Dockerfile,
and we ran make_appimage.sh inside that
- now we also need to run make_type2_runtime.sh, which builds and runs another docker container, so the old approach does not work
- follow-up https://github.com/spesmilo/electrum/pull/10019
- looks easier to just try to run build.sh, the outer script, which does all that
- makes the CI task more similar to what dev machines run
- at the cost of somewhat more compute
What changed, and why it matters
This is a routine change to Electrum's automated build configuration. It switches the CI (continuous integration) setup for building the Linux AppImage from running a sub-script inside a custom Docker container to running a top-level build script on a generic Docker-enabled virtual machine. There is no user-facing change, no wallet or cryptography change, and no security fix or vulnerability introduced based on the diff.
No security action required. Reviewers may optionally verify that build.sh has correct error handling and that the docker-builder instance has adequate resources and permissions, but this is normal CI maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies .cirrus.yml, replacing the container-based task (using contrib/build-linux/appimage/Dockerfile with CIRRUS_DOCKER_CONTEXT) with a compute_engine_instance using the cirrus-images docker-builder family. The build_script now invokes build.sh instead of make_appimage.sh, because build.sh orchestrates both make_appimage.sh and make_type2_runtime.sh, the latter of which itself runs another Docker container. This is a CI pipeline refactoring to support nested Docker builds.
Changed components
.cirrus.yml CI configurationcontrib/build-linux/appimage build pipelineInspect captured patch +5 / −5
diff --git a/.cirrus.yml b/.cirrus.yml
index c1a3529..13c2504 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -344,8 +344,10 @@ task:
only_if: $CIRRUS_CRON == ""
- trigger_type: automatic
only_if: $CIRRUS_CRON == "nightly"
- container:
- dockerfile: contrib/build-linux/appimage/Dockerfile
+ compute_engine_instance:
+ image_project: cirrus-images
+ image: family/docker-builder
+ platform: linux
cpu: 2
memory: 2G
pip_cache:
@@ -361,11 +363,9 @@ task:
- cat contrib/make_libsecp256k1.sh | sha256sum
- git ls-files -s contrib/build-linux/appimage/
build_script:
- - ./contrib/build-linux/appimage/make_appimage.sh
+ - ./contrib/build-linux/appimage/build.sh
binaries_artifacts:
path: "dist/*"
- env:
- CIRRUS_DOCKER_CONTEXT: contrib/build-linux/appimage
depends_on:
- "unittests: py3.10"
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.