What changed, and why it matters
This commit only adds comments to two GitHub workflow files explaining where API keys come from and what permissions they need. It does not change any code behavior, secrets handling, or access controls. There is no security issue here.
No action needed. This is a documentation-only CI commit with no security relevance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch is purely documentation-only. In .github/workflows/locale.yml it adds comments describing the Crowdin API key URL and required scopes. In .github/workflows/tests.yml it clarifies that COVERALLS_REPO_TOKEN is a repo token rather than a personal API token, adds a reference URL, and adds an else branch echoing when the token is missing. None of these changes alter execution paths, secret exposure, or permissions.
Changed components
.github/workflows/locale.yml.github/workflows/tests.ymlInspect captured patch +7 / −1
diff --git a/.github/workflows/locale.yml b/.github/workflows/locale.yml
index ef27b54..273006b 100644
--- a/.github/workflows/locale.yml
+++ b/.github/workflows/locale.yml
@@ -39,6 +39,10 @@ jobs:
- name: Push locale to Crowdin
# CROWDIN_API_KEY needs to be set in GitHub repository settings
# - api key is for crowdin account: "SomberNight_CI_BOT"
+ # ref https://crowdin.com/settings#api-key
+ # scope:
+ # - Projects/"Source files & strings" - read and write
+ # - Projects/"Translations" - read and write
env:
crowdin_api_key: ${{ secrets.CROWDIN_API_KEY }}
run: ./contrib/locale/push_locale.py
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
index 43f5fbb..df96be4 100644
--- a/.github/workflows/tests.yml
+++ b/.github/workflows/tests.yml
@@ -118,6 +118,8 @@ jobs:
if: matrix.python == '3.10' && !matrix.debug
env:
# 'COVERALLS_REPO_TOKEN' needs to be set in the GitHub repository settings
+ # This is a "repo token", NOT a "Personal API Token"!
+ # ref https://coveralls.io/github/spesmilo/electrum/settings
COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
CI_NAME: github-actions
CI_BUILD_NUMBER: ${{ github.run_id }}
@@ -128,7 +130,7 @@ jobs:
# the repo token will be empty when pull requests from forks get opened
# so we won't upload on every pull request, but it will run again
# with the token once the PR gets merged.
- run: if [ -n "$COVERALLS_REPO_TOKEN" ]; then coveralls; fi
+ run: if [ -n "$COVERALLS_REPO_TOKEN" ]; then coveralls; else echo "missing COVERALLS_REPO_TOKEN"; fi
# unittests using the ~same frozen dependencies that are used in the released binaries
# note: not using pinned pyqt here, due to "qml_gui" extra
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.