What the developer wrote
Authored by SomberNight
qml: fix: paying to openalias
regression from in https://github.com/spesmilo/electrum/pull/9993
7d0ac64d065a5d5b700507ac88fe3463553e913d
What changed, and why it matters
This is a small bug fix in Electrum's mobile-style QML user interface. A previous code change accidentally left OpenAlias payment addresses out of the list of recognized invoice types, so users trying to pay to an OpenAlias address (for example, a human-readable name like 'donate@example.com') would see an 'Unknown invoice' error instead of completing the payment. The patch simply adds OpenAlias back to the accepted list. It is a functionality regression fix, not a security vulnerability.
No security action required; treat as a normal regression fix. Optionally verify OpenAlias resolution still performs expected DNSSEC/TXT validation elsewhere before merging.
Security signals we found
No security-relevant signals in the diff
Change is a one-line inclusion of an existing enum value in an allow-list
No input validation weakening beyond restoring previously supported identifier type
Evidence from the diff
In electrum/gui/qml/qeinvoice.py, QEInvoiceParser’s invoice-type validation list omitted PaymentIdentifierType.OPENALIAS after refactor in PR #9993 (commit 7d0ac64d065a5d5b700507ac88fe3463553e913d). The fix adds OPENALIAS to the allowed set, restoring QML OpenAlias payment support. No cryptographic, parsing, or trust-boundary changes are present.
Changed components
electrum/gui/qml/qeinvoice.pyQML GUI invoice parserOpenAlias payment flowInspect captured patch +2 / −1
diff --git a/electrum/gui/qml/qeinvoice.py b/electrum/gui/qml/qeinvoice.py
index 8e3ce20..c3a9a8f 100644
--- a/electrum/gui/qml/qeinvoice.py
+++ b/electrum/gui/qml/qeinvoice.py
@@ -529,7 +529,8 @@ class QEInvoiceParser(QEInvoice):
PaymentIdentifierType.SPK, PaymentIdentifierType.BIP21,
PaymentIdentifierType.BIP70, PaymentIdentifierType.BOLT11,
PaymentIdentifierType.LNADDR, PaymentIdentifierType.LNURLP,
- PaymentIdentifierType.EMAILLIKE, PaymentIdentifierType.DOMAINLIKE
+ PaymentIdentifierType.EMAILLIKE, PaymentIdentifierType.DOMAINLIKE,
+ PaymentIdentifierType.OPENALIAS,
]:
self.validationError.emit('unknown', _('Unknown invoice'))
return
Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.