fix: outdated comment jsonrpc_timeout is for RPC calls, not wait_for_new_block (#1227)
What the developer wrote
Authored by Snezhkko
fix: outdated comment jsonrpc_timeout is for RPC calls, not wait_for_new_block (#1227)
What changed, and why it matters
This commit only changes a code comment to make it more accurate. It does not modify any actual program behavior, configuration, or security logic. There is no security issue here.
No action needed. This is a non-functional documentation/comment fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff updates a single inline comment in src/daemon.rs. The old comment incorrectly stated that the jsonrpc_timeout setting was meant to give wait_for_new_block more time. The new comment clarifies that the timeout applies to RPC calls in general. No executable code, defaults, or timeout values were changed.
Changed components
src/daemon.rs (comment only)Inspect captured patch +1 / −1
diff --git a/src/daemon.rs b/src/daemon.rs
index 6270801..d1d0277 100644
--- a/src/daemon.rs
+++ b/src/daemon.rs
@@ -80,7 +80,7 @@ fn read_cookie(path: &Path) -> Result<(String, String)> {
fn rpc_connect(config: &Config) -> Result<Client> {
let rpc_url = format!("http://{}", config.daemon_rpc_addr);
- // Allow `wait_for_new_block` to take a bit longer before timing out.
+ // Allow RPC calls to take longer before timing out.
// See https://github.com/romanz/electrs/issues/495 for more details.
let builder = jsonrpc::simple_http::SimpleHttpTransport::builder()
.url(&rpc_url)?
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.