What the developer wrote
Authored by Antoni Spaanderman
cache cf handles in DBStore::write (#1220)
What changed, and why it matters
This commit is a small performance optimization. It stores references to database column family handles in local variables before writing data, instead of fetching the same handle repeatedly inside each loop. There is no security change visible in the diff.
No security action needed. Treat as a routine performance improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch caches RocksDB column family handles (funding_cf, spending_cf, txid_cf, headers_cf) in DBStore::write and reuses them across put_cf calls. This reduces repeated lookups and is a pure refactor/optimization. No security boundary, input validation, cryptographic operation, or access control is modified.
Changed components
src/db.rs: DBStore::writeInspect captured patch +9 / −5
diff --git a/src/db.rs b/src/db.rs
index db0f568..c6b156b 100644
--- a/src/db.rs
+++ b/src/db.rs
@@ -284,19 +284,23 @@ impl DBStore {
pub(crate) fn write(&self, batch: &WriteBatch) {
let mut db_batch = rocksdb::WriteBatch::default();
+ let funding_cf = self.funding_cf();
for key in &batch.funding_rows {
- db_batch.put_cf(self.funding_cf(), key, b"");
+ db_batch.put_cf(funding_cf, key, b"");
}
+ let spending_cf = self.spending_cf();
for key in &batch.spending_rows {
- db_batch.put_cf(self.spending_cf(), key, b"");
+ db_batch.put_cf(spending_cf, key, b"");
}
+ let txid_cf = self.txid_cf();
for key in &batch.txid_rows {
- db_batch.put_cf(self.txid_cf(), key, b"");
+ db_batch.put_cf(txid_cf, key, b"");
}
+ let headers_cf = self.headers_cf();
for key in &batch.header_rows {
- db_batch.put_cf(self.headers_cf(), key, b"");
+ db_batch.put_cf(headers_cf, key, b"");
}
- db_batch.put_cf(self.headers_cf(), TIP_KEY, batch.tip_row);
+ db_batch.put_cf(headers_cf, TIP_KEY, batch.tip_row);
let mut opts = rocksdb::WriteOptions::new();
let bulk_import = self.bulk_import.load(Ordering::Relaxed);
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.