What the developer wrote
Authored by Yuki Kishimoto
Fix `server.features` response format
The current `server.features` implementation returns an invalid `hosts`
structure:
```json
"hosts": {"tcp_port": 50001}
```
According to the Electrum protocol, `hosts` must be a dictionary keyed by
hostname, where each value is a dictionary containing optional keys such as
`tcp_port` and/or `ssl_port`.
This change updates the response to the correct format, i.e.:
```json
{
"genesis_hash": "000000000019d6689c085ae165831e934ff763ae46a2a6c172b3f1b60a8ce26f",
"hosts": {
"127.0.0.1": {
"tcp_port": 50001
},
}
"protocol_max": "1.4",
"protocol_min": "1.4",
"pruning": null,
"server_version": "electrs/0.10.0",
"hash_function": "sha256"
}
```
See: https://electrumx.readthedocs.io/en/latest/protocol-methods.html#server-features
Signed-off-by: Yuki Kishimoto <yukikishimoto@protonmail.com>
What changed, and why it matters
This commit fixes the JSON response format of a network information method called server.features. Previously, the software told connecting clients about its TCP port in a malformed way that did not follow the Electrum protocol. The patch now wraps the port under the server's IP address, which is the correct shape. This is a protocol-compliance bug, not an obvious security vulnerability, but non-compliant responses can confuse or break Electrum wallet clients that rely on this data.
Treat as a normal bugfix. Update clients/servers to the patched version to avoid interoperability failures with strict Electrum protocol parsers. No emergency security response is indicated by the commit content.
Security signals we found
Protocol format compliance fix
Client interoperability issue
No input validation or memory-safety change
No authentication, authorization, or cryptography change
Evidence from the diff
The server.features Electrum RPC method was returning hosts as {“tcp_port”:
Changed components
src/electrum.rsserver.features RPC methodElectrum protocol response formattingInspect captured patch +8 / −3
diff --git a/src/electrum.rs b/src/electrum.rs
index fa67b1d..e6ef9c6 100644
--- a/src/electrum.rs
+++ b/src/electrum.rs
@@ -13,6 +13,7 @@ use serde_json::{self, json, Value};
use std::collections::{hash_map::Entry, HashMap};
use std::fmt;
use std::iter::FromIterator;
+use std::net::SocketAddr;
use std::str::FromStr;
use crate::{
@@ -150,7 +151,7 @@ pub struct Rpc {
daemon: Daemon,
signal: Signal,
banner: String,
- port: u16,
+ addr: SocketAddr,
}
impl Rpc {
@@ -174,7 +175,7 @@ impl Rpc {
daemon,
signal,
banner: config.server_banner.clone(),
- port: config.electrum_rpc_addr.port(),
+ addr: config.electrum_rpc_addr,
})
}
@@ -507,7 +508,11 @@ impl Rpc {
fn features(&self) -> Result<Value> {
Ok(json!({
"genesis_hash": self.tracker.chain().get_block_hash(0),
- "hosts": { "tcp_port": self.port },
+ "hosts": {
+ self.addr.ip().to_string(): {
+ "tcp_port": self.addr.port()
+ }
+ },
"protocol_max": PROTOCOL_VERSION,
"protocol_min": PROTOCOL_VERSION,
"pruning": null,
Why this scored 21/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.