What the developer wrote
Authored by pm47
Nits (#3183)
What changed, and why it matters
This commit contains two tiny cleanups: it fixes the order of flags in a shell command example in build documentation, and removes decorative ASCII table borders from a code comment describing the layout of an encrypted failure message. Neither change alters program behavior or fixes a security issue.
No security action needed. Treat as a normal documentation/comment cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff is purely cosmetic. BUILD.md changes rm ~/.m2/wrapper ~/.sbt -rf to rm -Rf ~/.m2/wrapper ~/.sbt, which is functionally equivalent (the -R and -f flags are the same regardless of order). FailureMessage.scala removes the top and bottom +---+ border lines from an existing comment block about the structure of an onion-encrypted failure message. No executable code is modified.
Changed components
BUILD.md documentationeclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/FailureMessage.scala comment formattingInspect captured patch +3 / −3
diff --git a/BUILD.md b/BUILD.md
index 29d432c..23f7d64 100644
--- a/BUILD.md
+++ b/BUILD.md
@@ -94,6 +94,6 @@ To make local development and testing easier, SNAPSHOT dependencies are not veri
To re-create the trusted checksums file, run:
```shell
-$ rm ~/.m2/wrapper ~/.sbt -rf
+$ rm -Rf ~/.m2/wrapper ~/.sbt
$ ./mvnw clean install -DskipTests -Daether.artifactResolver.postProcessor.trustedChecksums.record
```
diff --git a/eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/FailureMessage.scala b/eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/FailureMessage.scala
index 652cf4d..563fcce 100644
--- a/eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/FailureMessage.scala
+++ b/eclair-core/src/main/scala/fr/acinq/eclair/wire/protocol/FailureMessage.scala
@@ -193,9 +193,9 @@ object FailureMessageCodecs {
/**
* An onion-encrypted failure from an intermediate node:
- * +----------------+----------------------------------+-----------------+----------------------+-----+
+ *
* | HMAC(32 bytes) | failure message length (2 bytes) | failure message | pad length (2 bytes) | pad |
- * +----------------+----------------------------------+-----------------+----------------------+-----+
+ *
* Bolt 4: SHOULD set pad such that the failure_len plus pad_len is equal to 256: by always using the same size we
* ensure error messages are indistinguishable.
*/
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.