What the developer wrote
Authored by pm47
Add more tolerance in tests (#3199)
DER encoding size can vary by +- 3 bytes, not +- 2.
What changed, and why it matters
This commit only widens the allowed margin in a test assertion about DER-encoded ECDSA signature sizes, from plus/minus 2 bytes to plus/minus 3 bytes. It is a test-only change and does not alter production code, transaction validation, or cryptographic handling.
No security action required. Treat as routine test-maintenance noise.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In TransactionsSpec.scala, the assertion checking that an actual transaction weight stays within expected +/- 2 bytes for AnchorOutputsCommitmentFormat is relaxed to +/- 3 bytes. The comment explaining DER-encoding variability is unchanged. No production logic is modified.
Changed components
eclair-core/src/test/scala/fr/acinq/eclair/transactions/TransactionsSpec.scalaInspect captured patch +2 / −2
diff --git a/eclair-core/src/test/scala/fr/acinq/eclair/transactions/TransactionsSpec.scala b/eclair-core/src/test/scala/fr/acinq/eclair/transactions/TransactionsSpec.scala
index 513c548..9d33fd6 100644
--- a/eclair-core/src/test/scala/fr/acinq/eclair/transactions/TransactionsSpec.scala
+++ b/eclair-core/src/test/scala/fr/acinq/eclair/transactions/TransactionsSpec.scala
@@ -152,8 +152,8 @@ class TransactionsSpec extends AnyFunSuite with Logging {
case _: SimpleTaprootChannelCommitmentFormat => assert(actual == expected)
case _: AnchorOutputsCommitmentFormat =>
// ECDSA signatures are der-encoded, which creates some variability in signature size compared to the baseline.
- assert(actual <= expected + 2)
- assert(actual >= expected - 2)
+ assert(actual <= expected + 3)
+ assert(actual >= expected - 3)
}
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.