What the developer wrote
Authored by scgbckbone
fix tests
What changed, and why it matters
This commit only updates two test files to fix failing tests. It changes test input data and adds an address-format parameter that a helper function now requires. There is no change to the actual COLDCARD firmware or wallet code that users rely on, so it does not affect device security.
No security action needed; treat as routine test maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies testing/test_bip322.py and testing/test_multisig.py. In test_bip322.py a parametrized test case is switched from a mixed set of input script types (p2wpkh, p2sh-p2wpkh, p2pkh) to a uniform p2sh-p2wpkh set. In test_multisig.py the test_ms_sign_myself test now derives and passes an addr_fmt string (‘p2wsh’ or ‘p2sh’) to make_myself_wallet. These are purely test-suite adjustments.
Changed components
testing/test_bip322.pytesting/test_multisig.pyInspect captured patch +9 / −2
diff --git a/testing/test_bip322.py b/testing/test_bip322.py
index cecf17e..33a5cc5 100644
--- a/testing/test_bip322.py
+++ b/testing/test_bip322.py
@@ -283,7 +283,7 @@ def test_bip322_0th_input_witness_utxo_requires_zero_value(bip322_txn, start_sig
@pytest.mark.parametrize("ins", [
[["p2wpkh", None, None], ["p2wpkh", None, 10000000], ["p2wpkh", None, 10000000]],
- [["p2wpkh", None, None], ["p2sh-p2wpkh", None, 10000000], ["p2pkh", None, 10000000]],
+ [["p2sh-p2wpkh", None, None], ["p2sh-p2wpkh", None, 10000000], ["p2sh-p2wpkh", None, 10000000]],
[["p2pkh", None, None], ["p2wpkh", None, 10000000], ["p2sh-p2wpkh", None, 10000000]],
])
def test_bip322_Xth_input_witness_utxo(ins, bip322_txn, start_sign, cap_story, end_sign,
diff --git a/testing/test_multisig.py b/testing/test_multisig.py
index 94d5890..7d84a3c 100644
--- a/testing/test_multisig.py
+++ b/testing/test_multisig.py
@@ -1539,7 +1539,14 @@ def test_ms_sign_myself(M, use_regtest, make_myself_wallet, addr_fmt, num_ins, d
use_regtest()
# create a wallet, with 3 bip39 pw's
- keys, select_wallet = make_myself_wallet(M, do_import=(not incl_xpubs))
+ if addr_fmt == AF_P2WSH:
+ af = "p2wsh"
+ elif addr_fmt == AF_P2SH:
+ af = "p2sh"
+ else:
+ assert False
+
+ keys, select_wallet = make_myself_wallet(M, do_import=(not incl_xpubs), addr_fmt=af)
N = len(keys)
assert M<=N
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.