What the developer wrote
Authored by Peter D. Gray
debug helper
What changed, and why it matters
This is a tiny build-script change for the COLDCARD hardware wallet firmware. It makes two Makefile adjustments: the release-candidate build target now depends on a submodule-check step, and a cleanup command is silenced so it doesn't print to the screen. There is nothing here that affects device security, user funds, or runtime behavior.
No security action needed. Treat as normal build-maintenance commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies stm32/shared.mk. It adds ‘submods-match’ as a prerequisite of the ‘rc1’ target, ensuring submodules are verified before a release candidate is built. It also prefixes the ‘rm’ command in submods-match with ‘@’ so its output is suppressed during make. Both changes are build-hygiene/debugging improvements; no firmware code, cryptography, or user-facing functionality is changed.
Changed components
stm32/shared.mkInspect captured patch +2 / −2
diff --git a/stm32/shared.mk b/stm32/shared.mk
index e0e03d2..a49de56 100644
--- a/stm32/shared.mk
+++ b/stm32/shared.mk
@@ -112,7 +112,7 @@ release: submods-match code-committed block_height
# Make a release-candidate, faster.
.PHONY: rc1
-rc1:
+rc1: submods-match
$(SUBMAKE) clean # critical, or else you get a mix of debug/not
$(SUBMAKE) DEBUG_BUILD=0 all
$(SIGNIT) sign -b $(BUILD_DIR) -m $(HW_MODEL) $(VERSION_STRING) $(PROD_KEYNUM) -o rc1.bin
@@ -181,7 +181,7 @@ submods-match:
git submodule status $(SUBMODULES:%=../%) > sm-have.txt
@echo "Submodules: <WANT vs. >HAVE"
diff sm-want.txt sm-have.txt
- rm sm-have.txt sm-want.txt
+ @rm sm-have.txt sm-want.txt
@echo "Submodules are right revisions."
.PHONY: code-committed
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.