What changed, and why it matters
This commit simply reorganizes two existing user-preference settings ('Home Menu XFP' and 'Menu Wrapping') from the main Settings menu into a new submenu called 'Buried Settings'. There is no change to how these settings work, no new functionality, and no security-related code change.
No security action needed. This is a UI reorganization only.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff in shared/flow.py moves two ToggleMenuItem definitions (hmx and wa) out of SettingsMenu and into a newly created BuriedSettingsMenu, then adds a MenuItem(‘Buried Settings’, menu=BuriedSettingsMenu) entry in SettingsMenu. The toggle items, their storage keys, stories, predicates, and on_change handlers are unchanged. No cryptographic, authentication, or privilege code is modified.
Changed components
shared/flow.pyInspect captured patch +16 / −10
diff --git a/shared/flow.py b/shared/flow.py
index 8aae273..72eb72b 100644
--- a/shared/flow.py
+++ b/shared/flow.py
@@ -164,6 +164,21 @@ LoginPrefsMenu = [
MenuItem('Test Login Now', f=login_now, arg=1),
]
+
+# obscure settings, not more dangerous, just more personal
+BuriedSettingsMenu = [
+ ToggleMenuItem('Home Menu XFP', 'hmx', ['Only Tmp', 'Always Show'],
+ story=('Forces display of XFP (seed fingerprint) '
+ 'at top of main menu. Normally, XFP is shown only when '
+ 'temporary seed is active.\n\n'
+ 'Master seed is displayed as <XFP>, temporary seeds as [XFP].'),
+ predicate=has_real_secret,
+ on_change=goto_home),
+ ToggleMenuItem('Menu Wrapping', 'wa', ['Default', 'Always Wrap'],
+ story='''When enabled, allows scrolling past menu top/bottom \
+(wrap around). By default, this only happens in menus whose length is greater than 10.'''),
+]
+
SettingsMenu = [
# xxxxxxxxxxxxxxxx
MenuItem('Login Settings', menu=LoginPrefsMenu),
@@ -186,22 +201,13 @@ The signed transaction will be named <TXID>.txn, so the file name does not leak
MS-DOS tools should not be able to find the PSBT data (ie. undelete), but forensic tools \
which take apart the flash chips of the SDCard may still be able to find the \
data or filenames.'''),
- ToggleMenuItem('Menu Wrapping', 'wa', ['Default', 'Always Wrap'],
- story='''When enabled, allows scrolling past menu top/bottom \
-(wrap around). By default, this only happens in menus whose length is greater than 10.'''),
- ToggleMenuItem('Home Menu XFP', 'hmx', ['Only Tmp', 'Always Show'],
- story=('Forces display of XFP (seed fingerprint) '
- 'at top of main menu. Normally, XFP is shown only when '
- 'temporary seed is active.\n\n'
- 'Master seed is displayed as <XFP>, temporary seeds as [XFP].'),
- predicate=has_real_secret,
- on_change=goto_home),
ToggleMenuItem('Keyboard EMU', 'emu', ['Default Off', 'Enable'],
on_change=usb_keyboard_emulation,
predicate=has_secrets, # cannot generate BIP85 passwords without secret
story='''This mode adds a top-level menu item for typing \
deterministically-generated passwords (BIP-85), directly into an \
attached USB computer (as an emulated keyboard).'''),
+ MenuItem('Buried Settings', menu=BuriedSettingsMenu),
]
XpubExportMenu = [
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.