add note to "Verify Backup" that proper verify is attainable via Restore Backup
What the developer wrote
Authored by scgbckbone
add note to "Verify Backup" that proper verify is attainable via Restore Backup
What changed, and why it matters
This commit only changes the user-facing message shown after a backup file CRC check. It adds a note explaining that the CRC check only catches accidental corruption, not deliberate tampering, and that a more thorough verification can be done by starting a restore and stopping after decryption. There is no code behavior change, no security fix, and no vulnerability introduced.
No security action needed. This is a documentation/UX clarification. Review as part of normal release QA.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies a single string in shared/backups.py within verify_backup_file(). The function still performs only a CRC check on the backup file. The change is purely informational UI text: it clarifies the limitations of the CRC check and tells users they can verify decryptability by initiating a restore and aborting after decryption succeeds. No cryptographic, file-handling, or control-flow logic was altered.
Changed components
shared/backups.pyverify_backup_file() user messageInspect captured patch +5 / −1
diff --git a/shared/backups.py b/shared/backups.py
index 41baa3f..c881351 100644
--- a/shared/backups.py
+++ b/shared/backups.py
@@ -540,7 +540,11 @@ async def verify_backup_file(fname):
# might be already closed on vdisk case due to filesystem unmount/mount
pass
- await ux_show_story("Backup file CRC checks out okay.\n\nPlease note this is only a check against accidental truncation and similar. Targeted modifications can still pass this test.")
+ await ux_show_story("Backup file CRC checks out okay.\n\n"
+ "Please note this is only a check against accidental truncation and similar."
+ " Targeted modifications can still pass this test. You may further verify"
+ " this backup file by starting the normal restore process (Restore Backup)"
+ " and aborting it once decryption has been achieved.")
async def restore_complete(fname_or_fd, temporary=False, words=True, usb=False):
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.