What the developer wrote
Authored by scgbckbone
testing: fix bitcoind param list
What changed, and why it matters
This commit fixes a minor Python syntax bug in a test helper file. Two missing commas in a list of command-line arguments for a local Bitcoin test node (bitcoind) were added. Without the commas, Python would accidentally concatenate two strings into one invalid argument, which would cause the test setup to fail. This change only affects internal testing code and has no security relevance for COLDCARD users or real funds.
No security action needed. Treat as a normal test-infrastructure fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In testing/api.py, the Bitcoind class builds a list of CLI arguments for launching a regtest bitcoind instance. The patch adds trailing commas after ‘-listen=0’ and f’-rpcport={self.p2p_port}’, preventing Python from concatenating the adjacent string literals (e.g., ‘-listen=0’ + f’-port={self.p2p_port}’ becoming ‘-listen=0-port=…’). This is a test-only syntax/bug fix with no runtime effect on firmware or production behavior.
Changed components
testing/api.pyInspect captured patch +2 / −2
diff --git a/testing/api.py b/testing/api.py
index 918ec51..fee2f28 100644
--- a/testing/api.py
+++ b/testing/api.py
@@ -59,9 +59,9 @@ class Bitcoind:
"-fallbackfee=0.0002",
"-server=1",
"-keypool=1",
- "-listen=0"
+ "-listen=0",
f"-port={self.p2p_port}",
- f"-rpcport={self.rpc_port}"
+ f"-rpcport={self.rpc_port}",
]
)
signal.signal(signal.SIGTERM, self.cleanup)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.