What the developer wrote
Authored by scgbckbone
fix multisig test ms_sign_simple
What changed, and why it matters
This commit only changes a test file (testing/test_multisig.py). It fixes a test helper called ms_sign_simple by adding proper derivation path handling and adjusting how xpubs are included in test multisig wallets. There is no change to the actual COLDCARD firmware code that users run, so it cannot directly affect real device security.
No security action required. Treat as routine test maintenance. If the test was failing because of a real firmware behavior change, verify that the corresponding firmware behavior is already covered by other tests or release notes.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies testing/test_multisig.py. It adds a path_mapper function that derives correct BIP45/BIP48 paths based on address format (P2SH, P2WSH, P2SH-P2WSH), passes a common derivation prefix to import_ms_wallet, and restructures incl_xpubs handling so that when wallets are not imported from PSBT, the test still supplies proper xpub derivation paths. This appears to be a test-only fix to keep ms_sign_simple passing after changes to derivation-path expectations in the test framework or firmware under test.
Changed components
testing/test_multisig.pyInspect captured patch +22 / −2
diff --git a/testing/test_multisig.py b/testing/test_multisig.py
index a2a49d3..1220193 100644
--- a/testing/test_multisig.py
+++ b/testing/test_multisig.py
@@ -1393,6 +1393,8 @@ def fake_ms_txn(pytestconfig):
make_redeem_args = hack_change_out(i)
if violate_script_key_order:
make_redeem_args["violate_script_key_order"] = True
+ if path_mapper:
+ make_redeem_args["path_mapper"] = path_mapper
addr, scriptPubKey, scr, details = \
make_ms_address(M, keys, idx=i, addr_fmt=unmap_addr_fmt[style],
@@ -1461,19 +1463,37 @@ def test_ms_sign_simple(M_N, num_ins, dev, addr_fmt, clear_ms, incl_xpubs, impor
clear_ms()
+ if addr_fmt == AF_P2SH:
+ dd = "m/45h"
+ elif addr_fmt == AF_P2WSH:
+ dd = "m/48h/1h/0h/2h"
+ else:
+ dd = "m/48h/1h/0h/1h"
+
+ def path_mapper(idx):
+ kk = str_to_path(dd)
+ return kk + [0,0]
+
if incl_xpubs != "no-import":
do_import = True
+ incl_xpubs = None
else:
do_import = False
+
+ def incl_xpubs(idx, xfp, m, sk):
+ kk = str_to_path(dd)
+ bp = pack('<%dI' % (dd.count("/")+1), xfp, *kk)
+ return sk.node.serialize_public(), bp
+
if not bip67:
raise pytest.skip("cannot import unsorted multisig from PSBT")
- keys = import_ms_wallet(M, N, name='cli-test', accept=True, addr_fmt=addr_fmt,
+ keys = import_ms_wallet(M, N, name='cli-test', accept=True, addr_fmt=addr_fmt, common=dd,
do_import=do_import, descriptor=descriptor, bip67=bip67)
psbt = fake_ms_txn(num_ins, num_outs, M, keys, incl_xpubs=incl_xpubs, inp_af=addr_fmt,
outstyles=ADDR_STYLES_MS, change_outputs=[1] if has_change else [],
- bip67=bip67)
+ bip67=bip67, path_mapper=path_mapper)
with open(f'{sim_root_dir}/debug/last.psbt', 'wb') as f:
f.write(psbt)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.