What the developer wrote
Authored by Peter D. Gray
add comment
What changed, and why it matters
This commit only adds a plain-language comment ('# 10 years') next to an existing constant that sets how far in the future a transaction's locktime can be. No code behavior changed.
No action needed; this is a non-functional documentation-only change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff changes a single line in shared/psbt.py, replacing MAX_FUTURE_BLOCKS = const(10 * 365 * 144) with the same line plus an inline comment explaining that the value represents 10 years. The constant value and all logic remain identical.
Changed components
shared/psbt.pyInspect captured patch +1 / −1
### shared/psbt.py
@@ -38,7 +38,7 @@
# transaction version error
TX_VER_ERR = "bad txn version"
NO_KEY_ERR = "None of the keys involved in this transaction belong to this Coldcard"
-MAX_FUTURE_BLOCKS = const(10 * 365 * 144)
+MAX_FUTURE_BLOCKS = const(10 * 365 * 144) # 10 years
# single sha256 of b'BIP0322-signed-message'
BIP322_TAG_HASH = b'te\x84\xa1\x87/\xa1\x00AUN\xff\xa08\xd6\x12IB\xddy\xb4\xe5\x8aL\xda\x18N\x13\xdb\xe6,I'Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.