What the developer wrote
Authored by Peter D. Gray
nits
What changed, and why it matters
This is a tiny test-only change. It removes an unused function argument (`only_q1`) from a test and adds a short delay (`time.sleep(0.1)`) during a test that simulates user button presses. There is no change to the actual COLDCARD firmware code that users run, and nothing here affects security.
No security action needed. Treat as routine test maintenance.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies testing/test_hobble.py, a test file for the ‘hobble’ feature. The diff removes the unused only_q1 fixture parameter from test_h_seedxor and inserts a 0.1-second sleep after a simulated menu selection. These are code-quality/test-flakiness adjustments only; no firmware source is touched.
Changed components
testing/test_hobble.pyInspect captured patch +3 / −2
diff --git a/testing/test_hobble.py b/testing/test_hobble.py
index 9e83f82..554c422 100644
--- a/testing/test_hobble.py
+++ b/testing/test_hobble.py
@@ -453,8 +453,8 @@ def test_h_qrscan(en_okeys, set_hobble, scan_a_qr, need_keypress, press_cancel,
scr = cap_screen() # stays in scanning mode
assert 'KT Blocked' in scr
-def test_h_seedxor(set_hobble, need_keypress, press_cancel, cap_screen, only_q1,
- cap_story, press_select, pick_menu_item, settings_set):
+def test_h_seedxor(set_hobble, need_keypress, press_cancel, cap_screen,
+ cap_story, press_select, pick_menu_item, settings_set):
# can start import via seed XOR, but cannot include master seed phrase
# as part of it.
@@ -469,6 +469,7 @@ def test_h_seedxor(set_hobble, need_keypress, press_cancel, cap_screen, only_q1,
title, story = cap_story()
assert 'A/B/C' in story
press_select() # select 24 words
+ time.sleep(0.1)
title, story = cap_story()
assert 'Since you have' in story
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.