What the developer wrote
Authored by tadeubas
chore: removed Docker
What changed, and why it matters
This commit simply removes the project's Docker-based build instructions and Dockerfile. It also tweaks one git clone command in the README to use shallow submodules. There is no change to the actual COLDCARD firmware code, no bug fix, and no security patch.
No security action needed. Reviewers may want to confirm that an alternative supported build path is documented for users who previously relied on Docker.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit deletes the Dockerfile used to build a containerized simulator environment and removes the corresponding Docker build/run instructions from README.md. It additionally changes the recommended git clone command from --depth 1 --recursive to --depth 1 --shallow-submodules --recursive. No source code, cryptographic, or build-system logic is modified.
Changed components
Dockerfile (deleted)README.md documentationInspect captured patch +1 / −52
diff --git a/Dockerfile b/Dockerfile
deleted file mode 100644
index 35ffc5a..0000000
--- a/Dockerfile
+++ /dev/null
@@ -1,32 +0,0 @@
-FROM gcc:11.5.0-bullseye
-
-ENV DEBIAN_FRONTEND=noninteractive
-
-RUN apt-get update && apt-get install -y \
- git \
- make \
- python3 python3-venv python3-pip \
- swig \
- libpcsclite-dev pcscd \
- pkg-config \
- libffi-dev \
- xterm \
- autoconf automake libtool m4
-
-WORKDIR /build
-
-RUN git clone --depth 1 --recursive \
- https://github.com/Coldcard/firmware.git
-
-WORKDIR /build/firmware/unix
-
-# Build mpy-cross
-RUN make -C ../external/micropython/mpy-cross
-
-# Build simulator & tools
-RUN make setup
-RUN make ngu-setup
-RUN make
-
-# remove unnecessary git files
-RUN find /build/firmware -name ".git" -type d -prune -exec rm -rf '{}' +
\ No newline at end of file
diff --git a/README.md b/README.md
index 1e5a9e0..3aae27c 100644
--- a/README.md
+++ b/README.md
@@ -91,25 +91,6 @@ so at the top level, do this command:
pip install -r requirements.txt
```
-### Using Docker to build simulator
-Install [Docker Desktop or Docker Engine](https://docs.docker.com/desktop/) (don't forget to add your user to the docker group `sudo usermod -aG docker $USER` than logout and login again)
-
-```
-# Build simulator
-docker build -t coldcard-simulator .
-docker create --name cc coldcard-simulator
-docker cp cc:/build/firmware ./firmware
-docker rm cc
-
-# Install specific libffi7 (as new Ubuntu versions ship with libffi8 only)
-wget http://archive.ubuntu.com/ubuntu/pool/main/libf/libffi/libffi7_3.3-4_amd64.deb
-sudo dpkg -i libffi7_3.3-4_amd64.deb
-
-# Run simulator (remember to follow the OS specific instructions detailed below to install python and its dependencies)
-cd firmware/unix
-./simulator.py
-```
-
### macOS
[Python 3.5 or higher](https://www.python.org) and [Homebrew](https://brew.sh) is required.
@@ -200,7 +181,7 @@ apt install build-essential git python3 python3-pip libudev-dev gcc-arm-none-eab
# Get sources, this takes a long time (because of external libraries), then open
# Recommended (fast, minimal download; sufficient for building and running the simulator):
-git clone --depth 1 --recursive https://github.com/Coldcard/firmware.git
+git clone --depth 1 --shallow-submodules --recursive https://github.com/Coldcard/firmware.git
# Full clone (developers only; required for history, bisecting, or contributing):
git clone --recursive https://github.com/Coldcard/firmware.git
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.