improve UX responsivness for Key Expression
What the developer wrote
Authored by scgbckbone
improve UX responsivness for Key Expression
What changed, and why it matters
This commit adds a simple 'Generating...' progress message on screen while the COLDCARD device prepares a key expression export file. There is no security-relevant change; it is purely a user experience improvement to reassure the user that the device is busy.
No security action required; treat as routine UX improvement.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff inserts two lines at the start of make_key_expression_export() in shared/export.py: it imports the display helper and calls dis.fullscreen(‘Generating…’) before continuing with the existing key expression generation logic. No cryptographic, file handling, or protocol code is modified.
Changed components
shared/export.py: make_key_expression_export()Inspect captured patch +3 / −0
diff --git a/shared/export.py b/shared/export.py
index 52e8094..6a08b79 100644
--- a/shared/export.py
+++ b/shared/export.py
@@ -505,6 +505,9 @@ async def make_descriptor_wallet_export(addr_type, account_num=0, mode=None, int
async def make_key_expression_export(orig_der, fname_pattern="key_expr.txt"):
+ from glob import dis
+
+ dis.fullscreen('Generating...')
xfp = xfp2str(settings.get('xfp', 0)).lower()
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.