What the developer wrote
Authored by Peter D. Gray
cleanups
What changed, and why it matters
This commit is a minor cleanup. It removes an obsolete unused method from the PIN handling code and fixes a punctuation error in a user-facing message shown when a spending policy blocks an action. There is no security-relevant change.
No action needed; this is a non-security cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff removes PinAttempt.delay(), a method marked obsolete since Mk3 that only called self.roundtrip(1). It also changes a single string in ux_q1.py from ‘Blocked when Spending Policy is in force’ to ‘Blocked when Spending Policy is in force.’ (adding a period). No logic, access control, or cryptographic behavior is altered.
Changed components
shared/pincodes.pyshared/ux_q1.pyInspect captured patch +1 / −5
diff --git a/shared/pincodes.py b/shared/pincodes.py
index 95327a0..150eb26 100644
--- a/shared/pincodes.py
+++ b/shared/pincodes.py
@@ -341,10 +341,6 @@ class PinAttempt:
return self.state_flags
- def delay(self):
- # obsolete since Mk3, but called from login.py
- self.roundtrip(1)
-
def login(self):
# test we have the PIN code right, and unlock access if so.
chk = self.roundtrip(2)
diff --git a/shared/ux_q1.py b/shared/ux_q1.py
index 14ad3cd..bd7a488 100644
--- a/shared/ux_q1.py
+++ b/shared/ux_q1.py
@@ -947,7 +947,7 @@ class QRScannerInteraction:
whitelist.update({'xprv', 'words'})
if what not in whitelist:
- await ux_show_story("Blocked when Spending Policy is in force", title='Sorry')
+ await ux_show_story("Blocked when Spending Policy is in force.", title='Sorry')
return
if what == 'xprv':
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.