What the developer wrote
Authored by Peter D. Gray
nit
What changed, and why it matters
This is a tiny code cleanup in the COLDCARD simulator's Unix launcher. It moves the '-e' flag so it always appears before the command to run, instead of being added separately in two branches. There is no security-relevant change.
No action needed; this is a non-security code-style refactor.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff refactors how xterm_args is built in unix/simulator.py. Previously ‘-e’ was appended in an if/else depending on whether logging was enabled; now the ‘-e’ flag is appended once, uniformly, before cc_cmd when subprocess.Popen is called. This is a stylistic ‘nit’ with no functional or security impact.
Changed components
unix/simulator.pyInspect captured patch +2 / −4
diff --git a/unix/simulator.py b/unix/simulator.py
index 624d1e1..c636377 100755
--- a/unix/simulator.py
+++ b/unix/simulator.py
@@ -915,11 +915,9 @@ Q1 specials:
file_desc = os.open(logfile, os.O_WRONLY | os.O_CREAT | os.O_TRUNC, 0o644)
os.close(file_desc)
- xterm_args.extend(['-l', '-lf', logfile, '-e'])
- else:
- xterm_args.extend(['-e'])
+ xterm_args.extend(['-l', '-lf', logfile])
- xterm = subprocess.Popen(xterm_args + cc_cmd,
+ xterm = subprocess.Popen(xterm_args + ['-e'] + cc_cmd,
env=env,
stdin=subprocess.DEVNULL, stdout=subprocess.DEVNULL,
pass_fds=pass_fds, shell=False)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.