What the developer wrote
Authored by scgbckbone
move 2
What changed, and why it matters
This commit makes a tiny code change and adds a few test cleanup button presses. It does not appear to fix or introduce any security issue. The code change updates one call to a user-prompt function to include a new 'Electrum' label argument, likely matching a recent refactor in that helper function. The test change presses 'cancel' three extra times after a test step, probably to close leftover menus.
No security action needed. Treat as routine maintenance/test cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
In shared/multisig.py, the call to electrum_export_story(msg) is changed to electrum_export_story(‘Electrum’, msg), presumably because the signature of electrum_export_story was updated to require a wallet-type/name parameter. In testing/test_sign.py, three additional press_cancel() calls are added after a test_tx_explorer_goto_idx assertion, likely to dismiss any remaining UI screens before the next test. No cryptographic, authorization, or input-validation logic is modified.
Changed components
shared/multisig.pytesting/test_sign.pyInspect captured patch +4 / −1
diff --git a/shared/multisig.py b/shared/multisig.py
index 42e5a97..b325c2b 100644
--- a/shared/multisig.py
+++ b/shared/multisig.py
@@ -1518,7 +1518,7 @@ async def ms_wallet_electrum_export(menu, label, item):
msg = 'The new wallet will have derivation path:\n %s\n and use %s addresses.\n' % (
dsum, MultisigWallet.render_addr_fmt(ms.addr_fmt) )
- if await ux_show_story(electrum_export_story(msg)) != 'y':
+ if await ux_show_story(electrum_export_story("Electrum", msg)) != 'y':
return
await ms.export_electrum()
diff --git a/testing/test_sign.py b/testing/test_sign.py
index f12134e..06f10e1 100644
--- a/testing/test_sign.py
+++ b/testing/test_sign.py
@@ -3625,6 +3625,9 @@ def test_tx_explorer_goto_idx(fake_txn, start_sign, cap_story, use_testnet, need
num = num_outs - 1
assert title == f"{num}-{num}"
+ for _ in range(3):
+ press_cancel()
+
@pytest.mark.parametrize("segwit", [True, False])
def test_txn_nVersion_zero(segwit, fake_txn, start_sign, cap_story, goto_home):
Why this scored 11/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.