What the developer wrote
Authored by scgbckbone
proper label for Web 2FA warning
What changed, and why it matters
This is a tiny user-interface label fix. It changes the warning label shown when a spending policy requires web-based two-factor authentication from the generic text 'CCC' to the specific policy key name. There is no security vulnerability here.
No security action needed. Treat as a normal UI/labeling fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch modifies shared/ccc.py in the SpendingPolicy.check() method. It replaces psbt.warnings.append((‘CCC’, ‘Web 2FA required.’)) with psbt.warnings.append((pol.nvkey.upper(), ‘Web 2FA required.’)). This only affects the string label used in a PSBT warning and fixes a typo in a comment (‘acheive’ -> ‘achieve’). No logic, authorization, or cryptographic behavior changes.
Changed components
shared/ccc.pySpendingPolicy.check()PSBT warning label for Web 2FAInspect captured patch +2 / −2
diff --git a/shared/ccc.py b/shared/ccc.py
index fa80879..8b5f8c9 100644
--- a/shared/ccc.py
+++ b/shared/ccc.py
@@ -125,10 +125,10 @@ class SpendingPolicy(dict):
raise SpendPolicyViolation("whitelist: " + addr)
# Web 2FA
- # - slow, requires UX, and they might not acheive it...
+ # - slow, requires UX, and they might not achieve it...
# - wait until about to do signature
if pol.get('web2fa', False):
- psbt.warnings.append(('CCC', 'Web 2FA required.'))
+ psbt.warnings.append((pol.nvkey.upper(), 'Web 2FA required.'))
return True
async def web2fa_challenge(self, msg):
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.