AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 66 Bitcoin

bugfix: duplicate inputs

Public commit record

What the developer wrote

Authored by scgbckbone

28/100 · Opaque
bugfix: duplicate inputs
✓ Subject identifies a change! No meaningful explanatory body
The short version

What changed, and why it matters

This commit fixes a bug in the COLDCARD hardware wallet where a Bitcoin transaction could contain the same input coin twice without being detected. The patch now checks for duplicate inputs while the wallet is reviewing a transaction to sign. However, the fix only remembers the last 50 inputs, so duplicates more than 50 positions apart are still missed. The included test confirms this limitation.

Recommended action

Review whether the 50-input window is sufficient for real-world use; consider increasing the limit or using a full set for duplicate detection if memory permits. Verify that downstream signing/finalization cannot be abused when duplicates fall outside the window. Run the new tests and perform adversarial PSBT fuzzing around duplicate inputs.

Security signals we found

01

New runtime validation: duplicate input detection added to PSBT processing

02

Windowed detection only: capped at 50 previous inputs, leaving a known bypass

03

FatalPSBTIssue exception raised on detection

04

Test explicitly documents the 50-input limitation as accepted behavior

05

Fix touches transaction signing path, a security-critical code area

Risk score

Why this scored 66/100

Our methodology →
Potential impact 18/30
Exploitability 14/25
Stealth signal 10/15
Affected reach 12/15
Confidence 8/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.