What the developer wrote
Authored by Peter D. Gray
nits
What changed, and why it matters
This commit contains only trivial non-code changes: a comment rewording, a stylistic Python list change with identical behavior, a typo fix in a user-facing message, and a hyphenation fix in a test file docstring. There is no security-relevant change.
No security action needed. This is a cosmetic/documentation cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies four lines across three files. In nvstore.py, a comment about the ‘sssp’ setting is reworded for clarity. In trick_pins.py, range(sn, sn+1) is replaced with [sn], which is semantically equivalent for clearing a single slot, and a typo (‘if this PIN if known’) is corrected to ‘if this PIN is known’. In test_hobble.py, ‘read only’ is hyphenated to ‘read-only’. None of these changes alter program logic, access control, cryptography, or data handling.
Changed components
shared/nvstore.pyshared/trick_pins.pytesting/test_hobble.pyInspect captured patch +4 / −4
diff --git a/shared/nvstore.py b/shared/nvstore.py
index 9142432..aee417a 100644
--- a/shared/nvstore.py
+++ b/shared/nvstore.py
@@ -67,7 +67,7 @@ from utils import call_later_ms
# msas = multisig address show (do not censor multisig addresses)
# ccc = (complex) If present, CCC feature is enabled and key details stored here.
# ktrx = (privkey) Key teleport Rx has been started, this will be our keypair
-# sssp = (complex) If present, spending-policy (single signer) feature are defined
+# sssp = (complex) If present, a (single signer) spending-policy is defined (maybe disabled)
# lfr = (string) If present, the reason why Spending Policy blocked last transaction
# Stored w/ key=00 for access before login
diff --git a/shared/trick_pins.py b/shared/trick_pins.py
index fa38b20..6058c68 100644
--- a/shared/trick_pins.py
+++ b/shared/trick_pins.py
@@ -312,7 +312,7 @@ class TrickPinMgmt:
# remove all bypass pins, they are done w/ feature
for k, (sn,flags,arg) in self.tp.items():
if (flags & TC_FW_DEFINED) and (arg == TCA_SP_UNLOCK):
- self.clear_slots(range(sn, sn+1))
+ self.clear_slots([sn])
self.forget_pin(k)
@@ -716,7 +716,7 @@ hiding this item.''')
return
if (flags == TC_FW_DEFINED) and (arg == TCA_SP_UNLOCK):
- msg = "It will still be possible to change or disable the spending policy if this PIN if known."
+ msg = "It will still be possible to change or disable the spending policy if this PIN is known."
elif pin == WRONG_PIN_CODE:
msg = "This will hide what happens with wrong PINs from the menus but it will still be in effect."
else:
diff --git a/testing/test_hobble.py b/testing/test_hobble.py
index 4042a5c..4a136b6 100644
--- a/testing/test_hobble.py
+++ b/testing/test_hobble.py
@@ -22,7 +22,7 @@ When hobbled...
* notes hidden if the exist but access disabled in policy
* verify no settings menu
-- temp seeds are read only: no create, no rename, etc.
+- temp seeds are read-only: no create, no rename, etc.
- seed vault can be accessed tho
- login sequence
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.